-
Notifications
You must be signed in to change notification settings - Fork 0
fix(control-plane): refresh CO pin and gap baseline #1741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d26994b
8bbedc0
40f2f98
5f24cde
23a402b
1a39d22
9383c75
d92fa15
03008ee
ea45e21
e7d16ad
b81811d
fd32fe5
df70009
3688b0c
b09eb81
5cdc77f
44aef1a
48ed709
ddd60ac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ all five, and auto-optimize routing by cost. | |
|
|
||
| 1. **Vendoring, pinned**: `scripts/ci/contextual_orchestrator_review_sidecar.sh` | ||
| clones `ContextualWisdomLab/contextual-orchestrator` at an exact SHA | ||
| (`464da4715b495b5eaaa593eba3796e2d976ee0c9` today) into `RUNNER_TEMP`. The | ||
| (`212ff437dc297613289dba2e6064ade9942e07d8` today) into `RUNNER_TEMP`. The | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| source's `requirements.lock` is installed with `--require-hashes` and | ||
| `--no-deps`, so dependency resolution cannot silently move the reviewed | ||
| runtime. | ||
|
|
@@ -116,6 +116,13 @@ all five, and auto-optimize routing by cost. | |
| `contextual-orchestrator` main revision `464da4715b495b5eaaa593eba3796e2d976ee0c9`, which contains the | ||
| current provider-discovery and gateway contracts. The SHA remains immutable; | ||
| this is a reviewed dependency refresh, not a floating branch reference. | ||
| - **2026-09-02 amendment (second refresh, same day): advance the pin again after | ||
| contextual-orchestrator#1026.** The sidecar default advances a second time, | ||
| from `464da4715b495b5eaaa593eba3796e2d976ee0c9` to the exact | ||
| `contextual-orchestrator` main revision `212ff437dc297613289dba2e6064ade9942e07d8`, | ||
| which contains the admin model-group audit-refresh fix. Recorded as a | ||
| separate amendment rather than rewritten in place so the immediate-predecessor | ||
| history stays traceable. | ||
|
|
||
| ## Consequences | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,3 +42,17 @@ def test_missing_maintainer_secret_uses_bounded_job_oidc_exchange() -> None: | |
| assert "::add-mask::$app_token" in dispatch_step | ||
| assert "${{ github.token }}" not in dispatch_step | ||
| assert "GITHUB_TOKEN:" not in dispatch_step | ||
|
|
||
|
|
||
| def test_installation_token_contract_accepts_the_new_long_stateless_shape() -> None: | ||
| """Token validation must not assume the legacy GitHub App token length.""" | ||
| source = WORKFLOW_PATH.read_text(encoding="utf-8") | ||
| expected = """jq -er '.token | select(type == "string" and length > 0)'""" | ||
| # Keep the assertion tied to the actual jq expression, not to a comment or | ||
| # an unrelated length check elsewhere in the workflow. | ||
| assert expected in source | ||
| assert "length == 40" not in source | ||
| assert "length == 45" not in source | ||
| assert "cut -c1-40" not in source | ||
| long_stateless_token = "ghs_" + "x" * 516 | ||
| assert len(long_stateless_token) == 520 | ||
|
Comment on lines
+47
to
+58
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Comment on lines
+49
to
+58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win 변경된 워크플로를 직접 검증하도록 테스트를 연결하세요.
🤖 Prompt for AI Agents |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Newline tokens bypass empty fallback
A newline-only token leaves
app_tokenempty after command substitution but passes the condition. Eleven workflows then use an empty credential instead of their unavailable path.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.