Skip to content

fix(scheduler): dispatch reviews after thread updates #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 3 commits into from
Sep 1, 2026
Merged

fix(scheduler): dispatch reviews after thread updates #1496

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0dad21e
fix(scheduler): dispatch reviews after thread updates
seonghobae Aug 31, 2026
fc9a23a
Merge remote-tracking branch 'origin/main' into HEAD
seonghobae Aug 31, 2026
7d22228
Merge remote-tracking branch 'origin/main' into HEAD
seonghobae Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-review-merge-scheduler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ jobs:
MAX_PRS: ${{ github.event.client_payload.max_prs || inputs.max_prs || '100' }}
PROJECT_FLOW_INPUT: ${{ github.event.client_payload.project_flow || inputs.project_flow || vars.PROJECT_FLOW || '' }}
PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number || github.event.workflow_run.pull_requests[0].number || github.event.client_payload.pr_number || inputs.pr_number || '' }}
TRIGGER_REVIEWS: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_run' || github.event_name == 'push' || github.event_name == 'pull_request_target' || (github.event_name == 'repository_dispatch' && github.event.client_payload.trigger_reviews != false) || inputs.trigger_reviews == true }}
TRIGGER_REVIEWS: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_run' || github.event_name == 'push' || github.event_name == 'pull_request_target' || github.event_name == 'pull_request_review' || (github.event_name == 'repository_dispatch' && github.event.client_payload.trigger_reviews != false) || inputs.trigger_reviews == true }}
Comment thread
seonghobae marked this conversation as resolved.
REVIEW_DISPATCH_LIMIT_INPUT: ${{ github.event.client_payload.review_dispatch_limit || inputs.review_dispatch_limit || vars.REVIEW_DISPATCH_LIMIT || '1' }}
BRANCH_UPDATE_LIMIT_INPUT: ${{ github.event.client_payload.branch_update_limit || inputs.branch_update_limit || vars.BRANCH_UPDATE_LIMIT || '1' }}
ENABLE_AUTO_MERGE: ${{ github.event_name == 'schedule' || github.event_name == 'push' || github.event_name == 'pull_request_target' || github.event_name == 'workflow_run' || (github.event_name == 'repository_dispatch' && github.event.client_payload.enable_auto_merge != false) || inputs.enable_auto_merge == true }}
Expand Down
10 changes: 10 additions & 0 deletions tests/test_required_workflow_queue_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,16 @@ def test_unassociated_review_workflow_runs_do_not_scan_the_whole_pr_queue() -> N
assert "github.event.workflow_run.pull_requests[0].number" in workflow


def test_review_events_can_dispatch_after_threads_are_resolved() -> None:
"""Let the scheduler dispatch OpenCode when a review event clears its last blocker."""
workflow = workflow_text("pr-review-merge-scheduler.yml")
scan_job = workflow.split(" scan-pr-queue:", 1)[1].split(" org-queue-sweep:", 1)[0]

assert "github.event_name == 'pull_request_review'" in scan_job.split(
"TRIGGER_REVIEWS:", 1
)[1].splitlines()[0]


def test_org_queue_sweep_covers_target_repositories_on_a_heartbeat() -> None:
"""Guard the org-wide approved-PR fallback sweep contract.

Expand Down
Loading