fix(release): name nldesign as this app's previous App Store id - #422
Merged
Conversation
The App Store keys everything on the app id, so renaming <id> to thematiq made it a brand new store entry starting from nothing. The release workflow derives its version baseline from the git tags and info.xml of THIS repo, neither of which knows anything about what shipped as nldesign -- so the version line restarts below it. filinq was about to publish 0.0.40 while docudesk sits at 0.1.0-beta.3 on the store. The store has no version ordering rule (_check_permission validates existence and ownership only), so that uploads with a 200 and is then never offered to anyone already on the higher version. previous-app-id folds the old entry's published versions into the baseline, so the renamed app picks the line up instead of restarting it.
Contributor
Quality Report — ConductionNL/thematiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 2/2 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-27 17:09 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
pushed a commit
that referenced
this pull request
Aug 29, 2026
Clears the conflicts blocking the development -> beta release merge (#420). Every conflicting file is taken from development, and on each one development is the strictly newer side; beta's side is an older promotion of development itself (#379, 2026-08-26): .github/workflows/release.yml development carries #422, which declares nldesign as the previous App Store id. The store has no version-ordering rule, so without it the renamed app restarts its version line BELOW what nldesign already published, uploads with a 200, and is then never offered to anyone already installed. .github/workflows/code-quality development: a push to development must reach a verdict too (#428). package-lock.json development pins @conduction/nextcloud-vue 2.22.1, which carries the theme app-id resolution this rename depends on; beta still pins 2.15.0. composer.lock development: hydra-gates 1.10. Proof, not intent: the merged tree is byte-identical to origin/development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on ConductionNL/.github#593, which adds the
previous-app-idinput.The App Store keys everything on the app id, so renaming
<id>tothematiqmade it a brand new store entry starting from nothing. The release workflow derives its baseline from this repo's git tags andappinfo/info.xml, neither of which knows anything about what shipped asnldesign, so the version line restarts below it.nldesigncurrently serves 1.1.0-beta.1 on the store.The store has no version ordering rule —
_check_permissionvalidates existence and ownership only — so a lower version uploads with a 200 and is then never offered to anyone already on the higher one.previous-app-idfolds the old entry's published versions into the baseline, so the renamed app picks the line up instead of restarting it. Drop the input once thenldesignentry is retired.