fix(l10n): the Page layout title rendered English to a Dutch user - #286
Merged
Conversation
gate-101 manifest-l10n-coverage fails on development: the PageLayout page title has no key in l10n/nl.json, so a Dutch user sees the English source. Nothing else reports it -- check:l10n-js compares nl.json to nl.js, and a string absent from BOTH is in sync. Pagina-indeling is the idiomatic Dutch for a page-layout designer. There is no fleet compound to match; the nearest precedent is launchpad, which translates the bare Layout as Lay-out. Both catalogues are updated together: adding to nl.json alone would trade this gate for check:l10n-js.
gate-101 manifest-l10n-coverage fails on development: the PageLayout page title has no key in l10n/nl.json, so a Dutch user sees the English source. Nothing else reports it -- check:l10n-js compares nl.json to nl.js, and a string absent from BOTH is in sync. Pagina-indeling is the idiomatic Dutch for a page-layout designer. There is no fleet compound to match; the nearest precedent is launchpad, which translates the bare Layout as Lay-out. Both catalogues are updated together: adding to nl.json alone would trade this gate for check:l10n-js.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 28, 2026 13:07
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 871/871 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | 🚨 NO VERDICT — enabled but never ran | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-28 13:10 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gate-101 manifest-l10n-coverage, failing on
development.What is wrong
The
PageLayoutpage title has no key inl10n/nl.json, so a Dutch user sees the English source:It titles the widget-grid layout designer (
/pages/:id/layout, componentPageLayoutDesigner).Why nothing else caught it
From the gate's own message:
check:l10n-jscomparesnl.jsontonl.js, and a string absent from both is in sync. Only this gate looks at what the manifest actually renders.The translation
Page layout→Pagina-indeling— the idiomatic Dutch for a page-layout designer.There is no fleet compound to match: I checked opencatalogi, dossiq, openregister, thematiq and stackiq (none carry the key) and launchpad, which translates the bare
LayoutasLay-out. Flagging the choice rather than burying it, in case the fleet would rather standardise onPaginalay-out.Both catalogues
nl.jsis updated alongsidenl.json— adding tonl.jsonalone would simply trade this gate forcheck:l10n-js. This app'snl.jsuses a different style from launchpad's (4-space,"key": "value"), and the patch follows the local one.Verification
check_manifest_l10n_coverage.pyagainst this tree: no FAIL lines,checked 85 manifest string(s). Before the change it namedPage layoutexactly, matching CI's count of 1.nl.jsevaluated as real JavaScript (stubbingOC.L10N.register) to confirm it still parses and that the new key's value is identical in both catalogues.Why it reached development
Every Code Quality run on
developmentwas being cancelled rather than completed, so nothing reported it — see ConductionNL/.github#597 and the follow-up measurement in ConductionNL/.github#625.