Skip to content

fix(l10n): the Page layout title rendered English to a Dutch user - #286

Merged
rubenvdlinde merged 2 commits into
developmentfrom
fix/page-layout-needs-a-dutch-key
Aug 28, 2026
Merged

fix(l10n): the Page layout title rendered English to a Dutch user#286
rubenvdlinde merged 2 commits into
developmentfrom
fix/page-layout-needs-a-dutch-key

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Fixes gate-101 manifest-l10n-coverage, failing on development.

What is wrong

The PageLayout page title has no key in l10n/nl.json, so a Dutch user sees the English source:

FAIL no nl.json key: Page layout

It titles the widget-grid layout designer (/pages/:id/layout, component PageLayoutDesigner).

Why nothing else caught it

From the gate's own message: check:l10n-js compares nl.json to nl.js, and a string absent from both is in sync. Only this gate looks at what the manifest actually renders.

The translation

Page layoutPagina-indeling — the idiomatic Dutch for a page-layout designer.

There is no fleet compound to match: I checked opencatalogi, dossiq, openregister, thematiq and stackiq (none carry the key) and launchpad, which translates the bare Layout as Lay-out. Flagging the choice rather than burying it, in case the fleet would rather standardise on Paginalay-out.

Both catalogues

nl.js is updated alongside nl.json — adding to nl.json alone would simply trade this gate for check:l10n-js. This app's nl.js uses a different style from launchpad's (4-space, "key": "value"), and the patch follows the local one.

Verification

  • check_manifest_l10n_coverage.py against this tree: no FAIL lines, checked 85 manifest string(s). Before the change it named Page layout exactly, matching CI's count of 1.
  • nl.js evaluated as real JavaScript (stubbing OC.L10N.register) to confirm it still parses and that the new key's value is identical in both catalogues.

Why it reached development

Every Code Quality run on development was being cancelled rather than completed, so nothing reported it — see ConductionNL/.github#597 and the follow-up measurement in ConductionNL/.github#625.

gate-101 manifest-l10n-coverage fails on development: the PageLayout
page title has no key in l10n/nl.json, so a Dutch user sees the English
source. Nothing else reports it -- check:l10n-js compares nl.json to
nl.js, and a string absent from BOTH is in sync.

Pagina-indeling is the idiomatic Dutch for a page-layout designer. There
is no fleet compound to match; the nearest precedent is launchpad, which
translates the bare Layout as Lay-out.

Both catalogues are updated together: adding to nl.json alone would trade
this gate for check:l10n-js.
gate-101 manifest-l10n-coverage fails on development: the PageLayout
page title has no key in l10n/nl.json, so a Dutch user sees the English
source. Nothing else reports it -- check:l10n-js compares nl.json to
nl.js, and a string absent from BOTH is in sync.

Pagina-indeling is the idiomatic Dutch for a page-layout designer. There
is no fleet compound to match; the nearest precedent is launchpad, which
translates the bare Layout as Lay-out.

Both catalogues are updated together: adding to nl.json alone would trade
this gate for check:l10n-js.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/portaliq @ b2e7ca9

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-specs
check-manifest
format
check-l10n-js
check-schema-l10n
composer ✅ 104/104
npm ✅ 871/871
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman
Playwright 🚨 NO VERDICT — enabled but never ran
Hydra gates

Quality workflow — 2026-08-28 13:10 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 4f473cb into development Aug 28, 2026
39 checks passed
@rubenvdlinde
rubenvdlinde deleted the fix/page-layout-needs-a-dutch-key branch August 28, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant