fix(deps): nextcloud-vue 2.21.0, which restores the flow create button - #2951
Merged
rubenvdlinde merged 3 commits intoAug 28, 2026
Merged
Conversation
The E2E on development fails on both attempts:
flow-controls.spec.ts:173 flow controls render, and a flow can be
built, saved and run
getByRole("button", { name: "New flow" }) — element(s) not found
#2937 moved the flow list to an ordinary type:index over the named
source "flows". nextcloud-vue 2.20.0 shipped named sources (#800) but
read only their `columns` — `addLabel` and the routes were defined and
never read, so the migration lost the create button. nc-vue #818 fixes
exactly that and first ships in 2.21.0.
Verified against the PUBLISHED artifacts, not the source: 2.21.0/dist
carries the namedSource.addLabel branch, 2.20.0/dist does not.
The lock is regenerated with npm 11 (engines.npm ^11.0.0; npm 10 does not
implement min-release-age) and with the repo .npmrc in place — without
its min-release-age-exclude[]=@conduction/* the two-day cooldown would
have silently resolved BACKWARDS on a release-day version. The lock diff
is one line: no transitive package was added, removed or moved.
The E2E on development fails on both attempts:
flow-controls.spec.ts:173 flow controls render, and a flow can be
built, saved and run
getByRole("button", { name: "New flow" }) — element(s) not found
#2937 moved the flow list to an ordinary type:index over the named
source "flows". nextcloud-vue 2.20.0 shipped named sources (#800) but
read only their `columns` — `addLabel` and the routes were defined and
never read, so the migration lost the create button. nc-vue #818 fixes
exactly that and first ships in 2.21.0.
Verified against the PUBLISHED artifacts, not the source: 2.21.0/dist
carries the namedSource.addLabel branch, 2.20.0/dist does not.
The lock is regenerated with npm 11 (engines.npm ^11.0.0; npm 10 does not
implement min-release-age) and with the repo .npmrc in place — without
its min-release-age-exclude[]=@conduction/* the two-day cooldown would
have silently resolved BACKWARDS on a release-day version. The lock diff
is one line: no transitive package was added, removed or moved.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 175/175 | |||
| npm | ✅ | ✅ 545/545 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-28 06:21 UTC
Download the full PDF report from the workflow artifacts.
…-flow-create-button
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 175/175 | |||
| npm | ✅ | ✅ 545/545 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-28 07:42 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
deleted the
fix/nextcloud-vue-2.21.0-restores-the-flow-create-button
branch
August 28, 2026 07:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Playwright E2E failure on
development.The failure
Failed on both attempts, so not a flake. 63 other specs passed.
Cause
#2937 moved the flow list to an ordinary
type: "index"over the named sourceflows.nextcloud-vue 2.20.0 shipped named sources (nc-vue #800) but read only their
columns—addLabeland the routes were defined and never read. From nc-vue #818's own message:and in the code it replaces:
nc-vue #818 first ships in 2.21.0. This repo is pinned at 2.20.0, so the button genuinely does not render.
Verification
2.21.0/distcarries thenamedSource.addLabelbranch;2.20.0/distdoes not. A caret and a green source tree prove nothing about what installs.engines.npmis^11.0.0and npm 10 does not implementmin-release-age— regenerating under npm 10 would have rewritten an npm 11 lock with npm 10 semantics..npmrcin place. Itsmin-release-age=2plusmin-release-age-exclude[]=@conduction/*is what allows a first-party release-day version. Without the exclusion the cooldown does not fail loudly, it silently resolves backwards — the.npmrcsays so in as many words, and regenerating the lock in a bare scratch dir would have hit exactly that.Note
2.21.0 was published shortly before this PR. It is first-party and exempt from the cooldown by the
.npmrcrule above, and CI here — including the E2E that currently fails — is the check that it behaves. I could not run openregister's E2E locally.Surfaced by ConductionNL/.github#597:
developmenthad not produced a completed CI verdict in months because every run was cancelled.