Skip to content

Add controller-level test coverage for ExternalTrainingController, PageController, QtiImportController #564

Description

@rubenvdlinde

Follow-up to controller-test-coverage-security-critical (openspec/changes/controller-test-coverage-security-critical). That change added controller-level PHPUnit coverage for ActionMatrixController, KeyAdminController, and AuditPackExportController (previously zero coverage). Three more controllers still have zero dedicated controller-level test files at HEAD:

  • lib/Controller/ExternalTrainingController.php
  • lib/Controller/PageController.php
  • lib/Controller/QtiImportController.php

Note: ExternalTrainingController gained tenant-scoping unit tests as part of fix-cross-tenant-idor-planid-lookups (issueCredential/learnerCoverage only) — bulkRecord() is still untested. Follow the same pattern used in tests/Unit/Controller/ActionMatrixControllerTest.php / KeyAdminControllerTest.php / AuditPackExportControllerTest.php (mock constructor deps via createMock(), exercise the controller method directly, assert response status + body shape).

Ref: openspec/changes/controller-test-coverage-security-critical/tasks.md#task-5


Gemigreerd van Codeberg — oorspronkelijk Conduction/scholiq#48, geopend door rubenvdlinde op 2026-07-07.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

triageAwaiting triage

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions