fix(e2e): target the description field, not its helper button - #1635
Merged
rubenvdlinde merged 1 commit intoAug 28, 2026
Merged
Conversation
E2E fails on development:
Source — full CRUD with persistence
locator.fill: Element is not an <input>, <textarea>, <select>
locator resolved to <button class="cn-field-helper__trigger"
aria-label="Show the full description">
CnFieldHelper renders a Show the full description button beside the
field. Its aria-label matches /description/i as well, and getByLabel
resolved to the button rather than the input.
Both call sites move to getByRole(textbox), which only a real field can
satisfy. The create path had the same bug and was hiding it: its fill is
wrapped in .catch() as description optional, so the helper button
swallowed the value silently instead of failing.
Contributor
Quality Report — ConductionNL/integriq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 145/145 | |||
| npm | ✅ | ✅ 551/551 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | 🚨 NO VERDICT — enabled but never ran | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-28 13:23 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
deleted the
fix/description-selector-must-match-the-field-not-its-helper
branch
August 28, 2026 13:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the E2E failure on
development(1 failed, 178 passed).The failure
Cause
CnFieldHelperrenders a "Show the full description" button beside the field. Itsaria-labelmatches/description/itoo, sogetByLabel(/description/i).first()resolved to the button instead of the input, andfill()died.This is the selector-as-contract shape: a shared component grew an affordance whose accessible name collides with the field's, and every consumer targeting the field by label silently starts targeting the button.
The change
Both call sites move from
getByLabeltogetByRole('textbox', …), which only a real field can satisfy:The create path had the same bug and was hiding it
Line 184 does the same lookup, but its
fillis wrapped in.catch(() => { /* description optional */ }). So there the helper button swallowed the value silently — the create simply never set a description, and nothing failed. Only the edit path, which has nocatch, surfaced it.Fixed both rather than only the one that was red, since they are the same defect and one of them cannot report itself.
Deliberately not changed
The
.catch()on the create path. Removing it is a separate judgement about whether description is genuinely optional there, and this PR is about the selector.Verified:
node --experimental-strip-types --checkclean; nogetByLabel(/description/i)remains in the file; pushed file byte-identical to the intended patch.Surfaced once
developmentruns started completing again — see ConductionNL/.github#597 and #625.