Skip to content

chore(quality): take the canonical coverage-guard - #1241

Merged
rubenvdlinde merged 2 commits into
developmentfrom
chore/canonical-coverage-guard
Nov 4, 2026
Merged

rubenvdlinde merged 2 commits into
developmentfrom
chore/canonical-coverage-guard

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Replaces scripts/coverage-guard.php with the canonical copy from ConductionNL/.github main (quality-config/coverage-guard.php, merged in ConductionNL/.github#890, merge commit 923b0e7f9).

The canonical file splits the guard into small units. Its behaviour is unchanged: .github#890 pins it with a 100-case golden test (quality-config/tests/test-coverage-guard-golden.py).

  • Old file md5: 39174fe00c5fd73b8cc4dbfbc8ecba6e (the previous canonical copy)
  • New file md5: 4eb71392674b0bc3dfa42ac0fb802052
  • php -l passes; php scripts/coverage-guard.php --capabilities exits 0 and prints the same list as before (against, update-baseline, capabilities, changed-files, deletion-neutral).
  • Only scripts/coverage-guard.php changes. No analyser config in this repo scans scripts/.

Assisted-by: ClaudeCode:claude-opus-5-5

Copy quality-config/coverage-guard.php from ConductionNL/.github main (ConductionNL/.github#890, merge commit 923b0e7f9). The guard is split into small units with byte-identical behaviour, pinned by a 100-case golden test.

Assisted-by: ClaudeCode:claude-opus-5-5
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/hermiq @ 1c80280

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-specs ✅
check-manifest ✅
test-l10n ✅
format ❌
check-l10n-js ✅
check-schema-l10n ✅
check-bundle-budget ✅
composer ✅ ✅ 126/126
npm ❌ ✅ 838/838
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ✅ 2941/2941
Newman ✅ 15/15
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-02 08:30 UTC

Download the full PDF report from the workflow artifacts.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit dc8d5f7 into development Nov 4, 2026
48 of 49 checks passed
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/hermiq @ f9df1c1

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-specs ✅
check-manifest ✅
test-l10n ✅
format ✅
check-l10n-js ✅
check-schema-l10n ✅
check-bundle-budget ✅
composer ✅ ✅ 126/126
npm ✅ ✅ 854/854
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌ 3042/3049
Newman ✅ 15/15
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ✅

Quality workflow — 2026-11-04 10:48 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant