Repository navigation
chore(quality): take the canonical coverage-guard - #1241
Merged
Merged
Conversation
Copy quality-config/coverage-guard.php from ConductionNL/.github main (ConductionNL/.github#890, merge commit 923b0e7f9). The guard is split into small units with byte-identical behaviour, pinned by a 100-case golden test. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
November 2, 2026 07:01
Contributor
Quality Report — ConductionNL/hermiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-bundle-budget | ✅ | ||||
| composer | ✅ | ✅ 126/126 | |||
| npm | ❌ | ✅ 838/838 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 2941/2941 | ||||
| Newman | ✅ 15/15 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-02 08:30 UTC
Download the full PDF report from the workflow artifacts.
Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/hermiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-bundle-budget | ✅ | ||||
| composer | ✅ | ✅ 126/126 | |||
| npm | ✅ | ✅ 854/854 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 3042/3049 | ||||
| Newman | ✅ 15/15 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-11-04 10:48 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
scripts/coverage-guard.phpwith the canonical copy from ConductionNL/.github main (quality-config/coverage-guard.php, merged in ConductionNL/.github#890, merge commit 923b0e7f9).The canonical file splits the guard into small units. Its behaviour is unchanged: .github#890 pins it with a 100-case golden test (
quality-config/tests/test-coverage-guard-golden.py).39174fe00c5fd73b8cc4dbfbc8ecba6e(the previous canonical copy)4eb71392674b0bc3dfa42ac0fb802052php -lpasses;php scripts/coverage-guard.php --capabilitiesexits 0 and prints the same list as before (against,update-baseline,capabilities,changed-files,deletion-neutral).scripts/coverage-guard.phpchanges. No analyser config in this repo scansscripts/.Assisted-by: ClaudeCode:claude-opus-5-5