Skip to content

fix(dossiq): the admin settings factory passes the package tabs - #6622

Merged
rubenvdlinde merged 2 commits into
developmentfrom
quality/livepass-portaliq-dossiq-admin-settings
Nov 17, 2026
Merged

rubenvdlinde merged 2 commits into
developmentfrom
quality/livepass-portaliq-dossiq-admin-settings

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

AdminSettings has taken six constructor arguments since the package admin tabs (PackageAdminTabsInterface $packageTabs), but BespokeServiceRegistrar::registerAdminSettings() still built it with five. On any instance with dossiq enabled, every admin settings page (/settings/admin/*, not only dossiq's) answered 500:

Too few arguments to function OCA\Dossiq\Settings\AdminSettings::__construct(), 5 passed in .../BespokeServiceRegistrar.php on line 182 and exactly 6 expected

The factory now passes packageTabs from the container (the interface is aliased to PackageAdminTabs in ContractBindings).

Found by the portaliq live pass on a fresh Nextcloud 34.0.6 with OpenRegister main: portaliq's app-shell-and-admin spec could not open the admin section.

Verified

  • New BespokeServiceRegistrarTest::testTheAdminSettingsAreBuilt runs the registered factory with every service it asks for. It errors without the fix and passes with it; the class's 7 tests pass.
  • Live: with the fix deployed, /settings/admin/overview, /settings/admin/dossiq and /settings/admin/portaliq answer 200 (all three were 500), and portaliq's app-shell-and-admin spec passes its admin-section test.
  • Diff check: no NEW phpcs finding on touched lines. The three gate findings (gate-23, gate-66, gate-119) are repo-wide and none names these two files.
  • Not run to the end: composer check:strict. On this machine it runs past the 10-minute foreground limit (it was cut off in phpmd after lint passed and phpcs reported only inherited findings), so this PR is not merged on local green. CI or a reviewer decides.

This PR was prepared with AI assistance (Claude Code).

AdminSettings takes six constructor arguments since the package admin tabs, and
BespokeServiceRegistrar still built it with five. Every admin settings page of
an instance with dossiq answered 500 (Too few arguments). Found on a fresh
instance during the portaliq live pass.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde

Copy link
Copy Markdown
Contributor Author

Verified locally on the PR head merged with development b752ba6fb0: php -l OK; BespokeServiceRegistrarTest 7/7 OK; composer check:strict: phpcs 0 errors; full suite 18401 tests with 12 failures, all in CaseTypeRightsEnforcedAccessTest, which is red on development too and is not touched by this PR; the psalm InvalidCatch in PortalPermitController is also inherited. Merged on local green per the development merge policy.

@rubenvdlinde
rubenvdlinde merged commit 66504fa into development Nov 17, 2026
28 of 43 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/dossiq @ 64e47a5

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
check-vue3-compile ✅
test-l10n ❌
format ❌
check-schema-l10n ❌
check-l10n-js ✅
check-debt-ratchet ❌
check-types-e2e ✅
composer ❌ ✅ 129/129
npm ✅ ✅ 660/660
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌ 5760/5772 · 3 skipped
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-17 01:18 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant