Repository navigation
fix(dossiq): the admin settings factory passes the package tabs - #6622
Merged
rubenvdlinde merged 2 commits intoNov 17, 2026
Merged
Conversation
AdminSettings takes six constructor arguments since the package admin tabs, and BespokeServiceRegistrar still built it with five. Every admin settings page of an instance with dossiq answered 500 (Too few arguments). Found on a fresh instance during the portaliq live pass. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
November 17, 2026 00:28
Contributor
Author
|
Verified locally on the PR head merged with development b752ba6fb0: php -l OK; BespokeServiceRegistrarTest 7/7 OK; composer check:strict: phpcs 0 errors; full suite 18401 tests with 12 failures, all in CaseTypeRightsEnforcedAccessTest, which is red on development too and is not touched by this PR; the psalm InvalidCatch in PortalPermitController is also inherited. Merged on local green per the development merge policy. |
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-debt-ratchet | ❌ | ||||
| check-types-e2e | ✅ | ||||
| composer | ❌ | ✅ 129/129 | |||
| npm | ✅ | ✅ 660/660 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 5760/5772 · 3 skipped | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-17 01:18 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AdminSettingshas taken six constructor arguments since the package admin tabs (PackageAdminTabsInterface $packageTabs), butBespokeServiceRegistrar::registerAdminSettings()still built it with five. On any instance with dossiq enabled, every admin settings page (/settings/admin/*, not only dossiq's) answered 500:The factory now passes
packageTabsfrom the container (the interface is aliased toPackageAdminTabsinContractBindings).Found by the portaliq live pass on a fresh Nextcloud 34.0.6 with OpenRegister main: portaliq's
app-shell-and-adminspec could not open the admin section.Verified
BespokeServiceRegistrarTest::testTheAdminSettingsAreBuiltruns the registered factory with every service it asks for. It errors without the fix and passes with it; the class's 7 tests pass./settings/admin/overview,/settings/admin/dossiqand/settings/admin/portaliqanswer 200 (all three were 500), and portaliq's app-shell-and-admin spec passes its admin-section test.composer check:strict. On this machine it runs past the 10-minute foreground limit (it was cut off in phpmd after lint passed and phpcs reported only inherited findings), so this PR is not merged on local green. CI or a reviewer decides.This PR was prepared with AI assistance (Claude Code).