Repository navigation
fix(dossiq): live pass batch 1, working calendar and source adds work again - #6616
Merged
Merged
Conversation
Every task in these changes was ticked on development; their deltas are synced into the main specs and the four new capabilities get a written Purpose. repair-updates-installed-packages and package-upgrade-refreshes-untouched-rows stay open: their delta modifies REQ-CT-49, which only case-definition-packages (still open) adds. Assisted-by: ClaudeCode:claude-opus-5-5
openregister's SlaCalculator::add takes one SlaAddition since 10 Nov; WorkingDayRoll still called it with named from/value/unit/calendar, so every working-day question failed with "Unknown named parameter $from". On a live instance no case got receivedAt or termStartsAt, and working-day term ends fell back to calendar days. The unit fakes now take the SlaAddition and the calendars they hand back are real WorkingCalendar objects, so the old call shape fails the tests. Assisted-by: ClaudeCode:claude-opus-5-5
FileService::addFile returns an OCP\Files\File, which has getId() and no getFileId(), so storeFileOnObject always answered 0 and every document added to a case from a source (Woo gather, collect) was refused as write-failed. The unit fake returned an object with getFileId(); it now returns an OCP File double. Assisted-by: ClaudeCode:claude-opus-5-5
…erms - teardown sets a published seeded case type back to draft before the delete, the only state CaseTypeDeleteGuard deletes - deadlineInstance goes before case and deadlineDefinition before caseType, since an open term holds its case - cmmn-retirement opens the plan row's actions menu before completing - woo-gather-documents opens the action from the header menu and records a search plan first - woo-term-rolls files the request on 2026-11-27 (registrationDate): the term counts from receipt, not from startDate Assisted-by: ClaudeCode:claude-opus-5-5
woo-term-rolls (5.1), cmmn-retirement (5.1, 5.2) and woo-corpus (6.1) passed on a fresh Nextcloud 34 with openregister main. Requester notices 5.1, gather-documents 3.2 and cmmn 5.3 stay open with the reason. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…ames rows exactly Assisted-by: ClaudeCode:claude-opus-5-5
Without one every queued dossiq job requeues itself and writes nothing, so the acknowledgement of receipt that woo-requester-notices waits on never ran on a fresh instance. Assisted-by: ClaudeCode:claude-opus-5-5
…ps occ output The addFile fakes in WooGatherAddTest, ZaakdossierServiceTest and DocumentRedactionServiceTest answered an object with getFileId(), the shape openregister never returned. The background service account step in ci-seed.sh no longer discards occ output (CiSeedScriptTest). Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 16, 2026 22:16
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-debt-ratchet | ❌ | ||||
| check-types-e2e | ✅ | ||||
| composer | ❌ | ✅ 129/129 | |||
| npm | ✅ | ✅ 660/660 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 5710/5722 · 3 skipped | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-16 22:34 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live pass batch 1 for dossiq (decision 139): the open live and e2e tasks run against a throwaway Nextcloud 34 with openregister main, compose project
livepass-dossiq, never against :8080.Defects found on the live rig and fixed
SlaCalculator::addtakes oneSlaAdditionsince 10 Nov;WorkingDayRollstill passed namedfrom/value/unit/calendar, so every call failed with "Unknown named parameter $from". On a live instance no case gotreceivedAtortermStartsAt, and working-day term ends fell back to calendar days. The unit fakes now take theSlaAdditionand hand back realWorkingCalendarobjects, so the old call shape fails the tests.write-failed.DocumentRecordStore::storeFileOnObjectreadgetFileId()from theOCP\Files\FilethatFileService::addFilereturns (it hasgetId()). The fakes that modelled the wrong shape now return an OCP File double.Test and seed fixes
deadlineInstancebeforecase(an open term holds its case) anddeadlineDefinitionbeforecaseType.ci-seed.shsets a background service account. Without one every queued dossiq job requeues itself and writes nothing.registrationDate.OpenSpec
openspec validate --specs --strict: 357 passed.What ran locally (in place of CI)
php -land phpcs on changed PHP lines (0 new findings), eslint on changed e2e files (clean), unit tests of touched classes (green).composer check:strictonce. Red only on inherited findings: phpcs, phpmd, psalm (18) and phpstan (2) name none of the changed files; PHPUnit 18,323 tests with 12 failures, all inCaseTypeRightsEnforcedAccessTest, which this PR does not touch.npm run lint: 2 inherited errors (src/services/caseTypeRules.js,tests/Unit/golden/portal-contribution-manifests.json), neither touched here.AI-assisted: Claude Code (claude-opus-5-5) ran the live pass and wrote these changes.