Skip to content

fix(dossiq): live pass batch 1, working calendar and source adds work again - #6616

Merged
rubenvdlinde merged 11 commits into
developmentfrom
quality/livepass-dossiq-1
Nov 16, 2026
Merged

rubenvdlinde merged 11 commits into
developmentfrom
quality/livepass-dossiq-1

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Live pass batch 1 for dossiq (decision 139): the open live and e2e tasks run against a throwaway Nextcloud 34 with openregister main, compose project livepass-dossiq, never against :8080.

Defects found on the live rig and fixed

  • Working-day calendar never answered. openregister's SlaCalculator::add takes one SlaAddition since 10 Nov; WorkingDayRoll still passed named from/value/unit/calendar, so every call failed with "Unknown named parameter $from". On a live instance no case got receivedAt or termStartsAt, and working-day term ends fell back to calendar days. The unit fakes now take the SlaAddition and hand back real WorkingCalendar objects, so the old call shape fails the tests.
  • Every document added from a source was refused as write-failed. DocumentRecordStore::storeFileOnObject read getFileId() from the OCP\Files\File that FileService::addFile returns (it has getId()). The fakes that modelled the wrong shape now return an OCP File double.

Test and seed fixes

  • Teardown sets a published seeded case type back to draft before deleting it, and removes deadlineInstance before case (an open term holds its case) and deadlineDefinition before caseType.
  • ci-seed.sh sets a background service account. Without one every queued dossiq job requeues itself and writes nothing.
  • cmmn-retirement opens the plan row's menu; woo-gather-documents opens its action from the header menu, records a plan and searches inside its period; woo-term-rolls files on 2026-11-27 through registrationDate.

OpenSpec

  • Archived 13 fully ticked changes; the four new capabilities got a written Purpose. openspec validate --specs --strict: 357 passed.
  • Ticked after a green run: woo-term-is-computed-and-reported-right 5.1, retire-cmmn-caseplanstate 5.1 and 5.2, woo-request-corpus-collection 6.1. Open ones carry the reason in tasks.md.

What ran locally (in place of CI)

  • Diff check: php -l and phpcs on changed PHP lines (0 new findings), eslint on changed e2e files (clean), unit tests of touched classes (green).
  • composer check:strict once. Red only on inherited findings: phpcs, phpmd, psalm (18) and phpstan (2) name none of the changed files; PHPUnit 18,323 tests with 12 failures, all in CaseTypeRightsEnforcedAccessTest, which this PR does not touch.
  • npm run lint: 2 inherited errors (src/services/caseTypeRules.js, tests/Unit/golden/portal-contribution-manifests.json), neither touched here.
  • Playwright on the rig: woo-term-rolls, woo-requester-notices, woo-corpus, cmmn-retirement (3) and intake-says-when-the-term-starts REQ-TERM-040 (3) green.

AI-assisted: Claude Code (claude-opus-5-5) ran the live pass and wrote these changes.

Every task in these changes was ticked on development; their deltas are
synced into the main specs and the four new capabilities get a written
Purpose. repair-updates-installed-packages and
package-upgrade-refreshes-untouched-rows stay open: their delta modifies
REQ-CT-49, which only case-definition-packages (still open) adds.

Assisted-by: ClaudeCode:claude-opus-5-5
openregister's SlaCalculator::add takes one SlaAddition since 10 Nov;
WorkingDayRoll still called it with named from/value/unit/calendar, so
every working-day question failed with "Unknown named parameter $from".
On a live instance no case got receivedAt or termStartsAt, and working-day
term ends fell back to calendar days.

The unit fakes now take the SlaAddition and the calendars they hand back
are real WorkingCalendar objects, so the old call shape fails the tests.

Assisted-by: ClaudeCode:claude-opus-5-5
FileService::addFile returns an OCP\Files\File, which has getId() and no
getFileId(), so storeFileOnObject always answered 0 and every document
added to a case from a source (Woo gather, collect) was refused as
write-failed. The unit fake returned an object with getFileId(); it now
returns an OCP File double.

Assisted-by: ClaudeCode:claude-opus-5-5
…erms

- teardown sets a published seeded case type back to draft before the
  delete, the only state CaseTypeDeleteGuard deletes
- deadlineInstance goes before case and deadlineDefinition before
  caseType, since an open term holds its case
- cmmn-retirement opens the plan row's actions menu before completing
- woo-gather-documents opens the action from the header menu and records
  a search plan first
- woo-term-rolls files the request on 2026-11-27 (registrationDate): the
  term counts from receipt, not from startDate

Assisted-by: ClaudeCode:claude-opus-5-5
woo-term-rolls (5.1), cmmn-retirement (5.1, 5.2) and woo-corpus (6.1)
passed on a fresh Nextcloud 34 with openregister main. Requester notices
5.1, gather-documents 3.2 and cmmn 5.3 stay open with the reason.

Assisted-by: ClaudeCode:claude-opus-5-5
…ames rows exactly

Assisted-by: ClaudeCode:claude-opus-5-5
Without one every queued dossiq job requeues itself and writes nothing,
so the acknowledgement of receipt that woo-requester-notices waits on
never ran on a fresh instance.

Assisted-by: ClaudeCode:claude-opus-5-5
…ps occ output

The addFile fakes in WooGatherAddTest, ZaakdossierServiceTest and
DocumentRedactionServiceTest answered an object with getFileId(), the
shape openregister never returned. The background service account step
in ci-seed.sh no longer discards occ output (CiSeedScriptTest).

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 3f9117d into development Nov 16, 2026
4 of 7 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/dossiq @ 4e870bc

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
check-vue3-compile ✅
test-l10n ❌
format ❌
check-schema-l10n ❌
check-l10n-js ✅
check-debt-ratchet ❌
check-types-e2e ✅
composer ❌ ✅ 129/129
npm ✅ ✅ 660/660
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌ 5710/5722 · 3 skipped
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-16 22:34 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant