Repository navigation
refactor(support): move the last copies of the serialised array and row readings onto the shared helpers - #5872
Closed
rubenvdlinde wants to merge 2 commits into
Closed
rubenvdlinde wants to merge 2 commits into
rubenvdlinde wants to merge 2 commits into
Conversation
…adings Assisted-by: ClaudeCode:claude-opus-5-5
…ow readings onto the shared helpers CaseTypeStore::asRow(), SubCaseDeriver::asArray() and UnmatchedMailIntake::normaliseObjectRow() spell the array reading another way; CaseRelationStore, CaseObjectReader, ReceiptMoment and EventObjectPayload the nullable one. Each now delegates to SerialisedArray::of() or SerialisedRow::of(), both added here with the same content as in the sibling changes. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
November 11, 2026 15:10
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #5885 (the array readings) and #5886 (the row readings).
The static helpers added here repeated the reading
SearchesObjectsalready has, so the duplicated-fragment gate reported them as new duplication while other copies remained. Those two PRs route the same copies through the trait instead.AI-assisted: prepared with Claude Code (claude-opus-5-5); reviewed by a maintainer before merge.
Generated by Claude Code