Skip to content

feat: Enhance HCP compliance assessment experience (RFE-9086)#1299

Open
amogh27-web wants to merge 1 commit into
ComplianceAsCode:masterfrom
amogh27-web:feat/hcp-compliance-assessment-rfe-9086
Open

feat: Enhance HCP compliance assessment experience (RFE-9086)#1299
amogh27-web wants to merge 1 commit into
ComplianceAsCode:masterfrom
amogh27-web:feat/hcp-compliance-assessment-rfe-9086

Conversation

@amogh27-web

Copy link
Copy Markdown

Summary

This PR improves the compliance assessment experience for Hosted Control Planes (HCP/HyperShift) environments by introducing:

  1. HCP-aware platform utilities:

    • New HCPInfo struct for comprehensive HCP environment information
    • IsHyperShiftPlatform() helper function
    • GetHCPInfo() for detailed HCP context
    • GetHCPComplianceNote() for user guidance
  2. HCP compliance note annotation:

    • Automatically adds compliance.openshift.io/hcp-note annotation when running in HCP environment
    • Provides guidance on control plane compliance setup
  3. Pre-built HCP TailoredProfile templates:

    • CIS benchmark profile for HCP control plane
    • PCI-DSS benchmark profile for HCP control plane
    • Ready-to-use ScanSettingBinding example
  4. Enhanced documentation:

    • HCP compliance overview section with architecture table
    • References to sample configurations
  5. Enhancement proposal document:

    • Detailed design for HCP compliance improvements
    • User stories and acceptance criteria

Test plan

  • Unit tests pass for new platform utilities
  • Deploy on HyperShift management cluster and verify TailoredProfile templates work
  • Deploy on hosted cluster and verify HCP note annotation appears

Related

Made with Cursor

This commit improves the compliance assessment experience for Hosted
Control Planes (HCP/HyperShift) environments by introducing:

1. HCP-aware platform utilities:
   - New HCPInfo struct for comprehensive HCP environment information
   - IsHyperShiftPlatform() helper function
   - GetHCPInfo() for detailed HCP context
   - GetHCPComplianceNote() for user guidance

2. HCP compliance note annotation:
   - Automatically adds 'compliance.openshift.io/hcp-note' annotation
     when running in HCP environment
   - Provides guidance on control plane compliance setup

3. Pre-built HCP TailoredProfile templates:
   - CIS benchmark profile for HCP control plane
   - PCI-DSS benchmark profile for HCP control plane
   - Ready-to-use ScanSettingBinding example

4. Enhanced documentation:
   - HCP compliance overview section
   - Architecture explanation table
   - References to sample configurations

5. Enhancement proposal document:
   - Detailed design for HCP compliance improvements
   - User stories and acceptance criteria
   - Implementation notes

Fixes: RFE-9086
Signed-off-by: Amogh Shimpi <ashimpi@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci openshift-ci Bot requested a review from Anna-Koudelkova July 7, 2026 09:21
@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amogh27-web
Once this PR has been reviewed and has the lgtm label, please assign rhmdnd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown

Hi @amogh27-web. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant