fix(types): validate unsafe boundary casts - #1644
Open
open-inspect[bot] wants to merge 1 commit into
Open
Conversation
Terraform Validation Results
Pushed by: @open-inspect[bot], Action: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated nightly unsafe-cast remediation sweep. It addresses up to three currently qualifying unsafe TypeScript casts by parsing or guarding at the boundary, following the TypeScript Coding Standards for unsafe casts / parse-don't-assert and the Zod boundary-validation pattern established in PR #807.
packages/control-plane/src/session/message-queue.ts:681JSON.parse(originContext) as GitHubAutofixOriginbypassed the existing shared schema for persisted Autofix origin contextgithubAutofixOriginSchema.safeParse; invalid persisted origin keeps the existing log-and-omit behaviorpackages/control-plane/src/db/pr-autofix-feedback-store.ts:101JSON.parse(atob(cursor)) as Partial<ActivityCursor>asserted an opaque cursor before validationInvalid Autofix activity cursorpackages/control-plane/src/db/automation-store.ts:1145/:1148(pageResult.results ?? []) as ...androw.derived_status as AutomationInvocationStatusautomationInvocationStatusSchema; nullable D1 fields are modeled as.nullable()and malformed rows are not exposed as API stateVerification:
npm run build -w @open-inspect/sharednpm run build -w @open-inspect/control-planenpm run typechecknpm run lintnpm run formatnpm test -w @open-inspect/control-planeCreated with Open-Inspect