Skip to content

Expose skill autocomplete state to assistive technology #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
open-inspect wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Expose skill autocomplete state to assistive technology #1575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f246d2
fix(web): expose skill autocomplete as combobox
waclaude Aug 23, 2026
9ab91ca
fix(web): preserve prompt textarea semantics
waclaude Aug 28, 2026
383acf9
Merge remote-tracking branch 'origin/main' into fix/react-doctor-comb…
waclaude Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/web/src/components/prompt-skill-autocomplete.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ describe("PromptSkillTextarea", () => {
expect(screen.getByTestId("prompt-skill-suggestions")).not.toHaveAttribute("role");
expect(input).toHaveAttribute("aria-autocomplete", "list");
expect(input).not.toHaveAttribute("aria-expanded");
expect(screen.getByRole("status")).toHaveTextContent("2 managed skill suggestions available.");

await user.keyboard("{ArrowDown}{Enter}");
expect(input).toHaveValue("$release-notes ");
Expand Down Expand Up @@ -110,15 +111,18 @@ describe("PromptSkillTextarea", () => {
"true"
);
expect(screen.getByText("Loading managed skills...")).toBeInTheDocument();
expect(screen.getByRole("status")).toHaveTextContent("Loading managed skill suggestions.");

rerender(<Harness availableSkills={[]} />);
expect(screen.getByText("No managed skills match this session.")).toBeInTheDocument();
expect(screen.getByRole("status")).toHaveTextContent("No managed skill suggestions available.");
expect(screen.getByTestId("prompt-skill-suggestions")).toHaveClass("bottom-full");

rerender(<Harness loadState="error" availableSkills={[]} />);
expect(
screen.getByText("Managed skills could not be loaded. Try again shortly.")
).toBeInTheDocument();
expect(screen.getByRole("status")).toHaveTextContent("Managed skill suggestions unavailable.");
});

it("does not insert a completion beyond the prompt limit", async () => {
Expand Down
12 changes: 12 additions & 0 deletions packages/web/src/components/prompt-skill-autocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,15 @@ export const PromptSkillTextarea = forwardRef<HTMLTextAreaElement, PromptSkillTe
cursor !== null &&
sameCursor(dismissedAt.cursor, cursor);
const open = completion !== null && !dismissed;
const suggestionStatus = !open
? ""
: suggestionSource.status === "loading"
? "Loading managed skill suggestions."
: suggestionSource.status === "error"
? "Managed skill suggestions unavailable."
: matchingSkills.length === 0
? "No managed skill suggestions available."
: `${matchingSkills.length} managed skill suggestion${matchingSkills.length === 1 ? "" : "s"} available.`;

const setInputRef = useCallback(
(input: HTMLTextAreaElement | null) => {
Expand Down Expand Up @@ -217,6 +226,9 @@ export const PromptSkillTextarea = forwardRef<HTMLTextAreaElement, PromptSkillTe
onSelect?.(event);
}}
/>
<span role="status" className="sr-only">
{suggestionStatus}
</span>
{open && completion && (
<PromptSkillSuggestionPanel
id={listboxId}
Expand Down
Loading