Skip to content

Skip Windows cloud DSN setup when cloud tests are disabled - #590

Merged
slabko merged 1 commit into
masterfrom
skip-cloud-dsn-without-secrets
Sep 25, 2026
Merged

slabko merged 1 commit into
masterfrom
skip-cloud-dsn-without-secrets

Conversation

@slabko

@slabko slabko commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #589. Windows still configured cloud DSNs unconditionally, even when the cloud tests were skipped. With unavailable secrets, this passes an empty Password= property to Add-OdbcDsn, causing the DSN setup step to fail.

  • Move both cloud DSNs into a dedicated step guarded by the same cloud-enabled, Release, and x64 conditions as database creation and cloud tests.
  • Keep local DSN setup and DSN listing unconditional.

Validation

  • Parsed the updated workflow as YAML.
  • Checked all 8 combinations of cloud availability, build type, and architecture.
  • Verified all six DSN commands are preserved and other existing steps are unchanged.
  • git diff --check passed.
  • Windows execution remains to be verified by CI.

@slabko
slabko requested a review from mzitnik as a code owner September 25, 2026 12:03
@slabko
slabko merged commit 703638b into master Sep 25, 2026
20 checks passed
@slabko
slabko deleted the skip-cloud-dsn-without-secrets branch September 25, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants