Skip to content

Mod. LinkConstructor. Changing all links on the settings page to LinkConstructor#826

Merged
AntonV1211 merged 7 commits into
devfrom
link_contruct_av
Jul 2, 2026
Merged

Mod. LinkConstructor. Changing all links on the settings page to LinkConstructor#826
AntonV1211 merged 7 commits into
devfrom
link_contruct_av

Conversation

@AntonV1211

Copy link
Copy Markdown
Contributor

@AntonV1211 AntonV1211 changed the title Mod. LinkConstructor. Translation of all links on the settings page to LinkConstructor Mod. LinkConstructor. Changing all links on the settings page to LinkConstructor Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.70%. Comparing base (80253e6) to head (2c6da5e).

Files with missing lines Patch % Lines
inc/cleantalk-settings.php 76.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #826      +/-   ##
============================================
+ Coverage     26.70%   27.70%   +1.00%     
  Complexity     5800     5800              
============================================
  Files           278      278              
  Lines         24561    24559       -2     
============================================
+ Hits           6558     6805     +247     
+ Misses        18003    17754     -249     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates settings-page and long-description (“hint”) links from hardcoded URLs/UTM placeholders to LinkConstructor::buildCleanTalkLink(), centralizing UTM generation and adding regression tests to prevent future link/UTM drift.

Changes:

  • Added new UTM presets to Cleantalk\ApbctWP\LinkConstructor for long-description hints and settings-page links.
  • Replaced hardcoded settings-page links (and removed {utm_mark} substitution logic) with LinkConstructor::buildCleanTalkLink() calls.
  • Added a comprehensive PHPUnit test suite covering preset presence and exact URL outputs for migrated links.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
tests/ApbctWP/TestSettingsLongDescriptionLinks.php Adds regression tests validating link construction and required UTM presets for settings long-descriptions and settings-page links.
lib/Cleantalk/ApbctWP/LinkConstructor.php Introduces new UTM preset entries for migrated hint/settings links.
inc/cleantalk-settings.php Replaces hardcoded URLs and {utm_mark} logic with LinkConstructor-built links across settings UI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread inc/cleantalk-settings.php
Comment thread inc/cleantalk-settings.php
Comment thread inc/cleantalk-settings.php
Comment thread inc/cleantalk-settings.php

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment thread inc/cleantalk-settings.php Outdated
Comment thread inc/cleantalk-settings.php Outdated
Comment thread inc/cleantalk-settings.php Outdated
AntonV1211 and others added 5 commits July 2, 2026 14:00
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@AntonV1211
AntonV1211 merged commit d87a374 into dev Jul 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants