Mod. LinkConstructor. Changing all links on the settings page to LinkConstructor#826
Merged
Conversation
…o LinkConstructor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #826 +/- ##
============================================
+ Coverage 26.70% 27.70% +1.00%
Complexity 5800 5800
============================================
Files 278 278
Lines 24561 24559 -2
============================================
+ Hits 6558 6805 +247
+ Misses 18003 17754 -249 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates settings-page and long-description (“hint”) links from hardcoded URLs/UTM placeholders to LinkConstructor::buildCleanTalkLink(), centralizing UTM generation and adding regression tests to prevent future link/UTM drift.
Changes:
- Added new UTM presets to
Cleantalk\ApbctWP\LinkConstructorfor long-description hints and settings-page links. - Replaced hardcoded settings-page links (and removed
{utm_mark}substitution logic) withLinkConstructor::buildCleanTalkLink()calls. - Added a comprehensive PHPUnit test suite covering preset presence and exact URL outputs for migrated links.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tests/ApbctWP/TestSettingsLongDescriptionLinks.php |
Adds regression tests validating link construction and required UTM presets for settings long-descriptions and settings-page links. |
lib/Cleantalk/ApbctWP/LinkConstructor.php |
Introduces new UTM preset entries for migrated hint/settings links. |
inc/cleantalk-settings.php |
Replaces hardcoded URLs and {utm_mark} logic with LinkConstructor-built links across settings UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/35787