Skip to content

Fix. SFW. Update SFW fix#825

Merged
AntonV1211 merged 4 commits into
devfrom
fix_sfw_local_av
Jun 30, 2026
Merged

Fix. SFW. Update SFW fix#825
AntonV1211 merged 4 commits into
devfrom
fix_sfw_local_av

Conversation

@AntonV1211

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 29, 2026 10:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts HTTPMultiRequestService to better handle edge cases in multi-download workflows (notably SFW updates) by validating multi-request results before processing and normalizing CommonRequest::request() output when only one URL is requested.

Changes:

  • Reordered validation in fillMultiContract() so non-array results are rejected before accessing array keys.
  • Updated sendRequests() to normalize the single-URL response into the associative format expected by fillMultiContract().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/Cleantalk/ApbctWP/HTTP/HTTPMultiRequestService.php Outdated
Comment thread lib/Cleantalk/ApbctWP/HTTP/HTTPMultiRequestService.php
Comment thread lib/Cleantalk/ApbctWP/HTTP/HTTPMultiRequestService.php Outdated
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.68%. Comparing base (de47160) to head (81776a1).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev     #825   +/-   ##
=========================================
  Coverage     26.68%   26.68%           
+ Complexity     5683     5682    -1     
=========================================
  Files           270      270           
  Lines         24260    24260           
=========================================
  Hits           6473     6473           
  Misses        17787    17787           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings June 29, 2026 11:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread lib/Cleantalk/ApbctWP/HTTP/HTTPMultiRequestService.php
Comment thread lib/Cleantalk/ApbctWP/HTTP/HTTPMultiRequestService.php Outdated
Comment thread lib/Cleantalk/ApbctWP/HTTP/HTTPMultiRequestService.php Outdated
@AntonV1211
AntonV1211 merged commit 7fe7f0b into dev Jun 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants