Fix. SFW. Update SFW fix#825
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts HTTPMultiRequestService to better handle edge cases in multi-download workflows (notably SFW updates) by validating multi-request results before processing and normalizing CommonRequest::request() output when only one URL is requested.
Changes:
- Reordered validation in
fillMultiContract()so non-array results are rejected before accessing array keys. - Updated
sendRequests()to normalize the single-URL response into the associative format expected byfillMultiContract().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #825 +/- ##
=========================================
Coverage 26.68% 26.68%
+ Complexity 5683 5682 -1
=========================================
Files 270 270
Lines 24260 24260
=========================================
Hits 6473 6473
Misses 17787 17787 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.