Skip to content

Reset worker state after collection is finished. Closes #164 #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
umesh-timalsina wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reset worker state after collection is finished. Closes #164 #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc702ae
Reset worker state after collection is finished. Closes #164
umesh-timalsina Oct 13, 2023
bbf0cd6
Add option to keep workers during shutdown instead
umesh-timalsina Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion chimerapy/orchestrator/cli/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ async def aorchestrate(config: ChimeraPyPipelineConfig) -> None:
"manager.timeout.worker-shutdown", config.timeouts.shutdown_timeout
)

await manager.async_shutdown()
await manager.async_reset()
await manager.async_shutdown(shutdown_workers=config.keep_remote_workers)
print("Shutting down local workers...")
for worker in local_workers:
await worker.async_shutdown()
Expand Down
5 changes: 5 additions & 0 deletions chimerapy/orchestrator/models/pipeline_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@ class ChimeraPyPipelineConfig(BaseModel):
description="The timeouts for the pipeline operation.",
)

keep_remote_workers: bool = Field(
default=True,
description="If true, keep remote workers after pipeline has finished collection.",
)

def instantiate_manager(self) -> cpe.Manager:
m = cpe.Manager(
**self.manager_config.model_dump(
Expand Down