Add trailer download functionality with TMDb and YouTube integration - #36
Add trailer download functionality with TMDb and YouTube integration#36knom wants to merge 3 commits into
Conversation
|
Only HOOK is, PYTHON3 must be installed in the container image / machine. |
|
@CherryFloors please take a look and let me know what you think! |
|
BTW.. for library selection I have followed the pattern of #32. |
- Implemented trailer downloading logic in a new TrailerDownloader class. - Added scheduled task for automatic trailer downloads. - Added necessary dependencies for TMDb and YouTube downloading. - Introduced new configuration options for TMDb API key and trailer download libraries. - Updated HTML configuration to support new features. - Updated README
|
Hi @knom , Sorry for not replying to this PR sooner. You have done alot of work here and I think this functionality would be extremely useful/desirable for certain users and I had suspected I would get something like this in the form of a feature request. Unfortunately I feel strongly that this plugin should be very limited in scope and only provide a list of intros based on media that already exists in the server. I don't want it to also be responsible for gathering or curating media, whether its trailers or pre-rolls. Partially due to the increased modularity that provides when installing plugins but also due to my limitation in bandwidth for supporting features like those. As I said before, I do think people would enjoy a plugin like this and I encourage you to use what you have done here to create one. Maybe call it "Trailer Downloader" or "Pre Roll Content Curator" and expand to downloading pre roll content as well. Take whatever you need from this repo to get it started. I will happily take a PR edit to the README that provides a link to your project when you have it up and running. |
| public int NumberOfTrailers { get; set; } | ||
| public bool TrailerConsumeMode { get; set; } | ||
|
|
||
| public string TmdbApiKey { get; set; } |
There was a problem hiding this comment.
Something to consider if you implement this in your own plugin is that jellyfin actually stores trailer URLs from TMDB or other metadata providers in the media meta data. This is how it plays trailers from youtube when you dont have local trailers with your media.
You should just be able to query the jellyfin server for the youtube urls without needing to reach out to TMDB with an API key. Could simplify things for you and your users.
2 participants
A new scheduled task to download trailers from youtube to the local machine:
Whats new: