Rate-limit RESYNCING HARD log spam to at most once per second#234
Draft
W-Floyd wants to merge 1 commit into
Draft
Rate-limit RESYNCING HARD log spam to at most once per second#234W-Floyd wants to merge 1 commit into
W-Floyd wants to merge 1 commit into
Conversation
Flooding resync logs competed with audio Wi-Fi traffic and called esp_wifi_sta_get_ap_info + heap_caps queries on every resync iteration. Both RESYNCING HARD 1 and 2 now share a single timestamp gate; the expensive diagnostics only run when the log actually fires. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Do you have those problems when using udp Logger? |
Author
|
"using" meaning having a client connected to consume logs? It seemed the same either way. Much like in #232 I seem to be having better success since tuning other parameters. I've also disabled udp logging in my builds entirely right now, so I'll need to revisit this. Can probably close though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thoughts on rate limiting resync logs? I've been having issues with resync "storms", where once I player falls out of sync it really struggles to come back into sync. Trying this out, I seem to have more success, but still iffy. Possibly related to #226?
Overall it'd be nice to be able to turn off entirely instead, tracked in AchimPieters/esp32-udp-logger#9 already.
Flooding resync logs competed with audio Wi-Fi traffic and called esp_wifi_sta_get_ap_info + heap_caps queries on every resync iteration. Both RESYNCING HARD 1 and 2 now share a single timestamp gate; the expensive diagnostics only run when the log actually fires.