Skip to content

A0-4250: Substrate v1.5.0 - #1677

Merged
lesniak43 merged 24 commits into
mainfrom
A0-4250-substrate-v1.5.0
Apr 23, 2024
Merged

A0-4250: Substrate v1.5.0#1677
lesniak43 merged 24 commits into
mainfrom
A0-4250-substrate-v1.5.0

Conversation

@lesniak43

@lesniak43 lesniak43 commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

Description

Updating Substrate to v1.5.0

We postpone proper integration of paritytech/polkadot-sdk#1370 (this will be done before the next release).

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have bumped aleph-client version if relevant

@lesniak43
lesniak43 marked this pull request as ready for review April 22, 2024 11:26

@timorleph timorleph left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments but mostly looks good.

Comment thread bin/node/src/service.rs Outdated
Comment thread finality-aleph/src/lib.rs
Comment thread finality-aleph/src/network/gossip/mock.rs Outdated
Comment thread finality-aleph/src/network/gossip/mod.rs Outdated
Comment thread finality-aleph/src/network/gossip/service.rs Outdated
Comment thread finality-aleph/src/network/mock.rs Outdated
Comment thread finality-aleph/src/network/substrate.rs Outdated
Comment thread finality-aleph/src/network/substrate.rs Outdated
Comment thread finality-aleph/src/network/substrate.rs Outdated
Comment thread finality-aleph/src/testing/network.rs Outdated

@kostekIV kostekIV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread bin/node/src/service.rs Outdated
Comment thread finality-aleph/src/network/gossip/service.rs
@lesniak43
lesniak43 added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit ff98e89 Apr 23, 2024
@lesniak43
lesniak43 deleted the A0-4250-substrate-v1.5.0 branch April 23, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants