Cleanup/Reorganize app.js#42
Open
nick-w-nick wants to merge 11 commits into
Open
Conversation
There was a problem hiding this comment.
I think that "reorganized middleware imports and usage" is not a useful change as doesn't follow clean code best practices. All dependencies must be declared to the top of the file. This allow other developers to see quickly what dependencies are used in the current file.
Author
|
@ronaldtorres I understand, it's just a specific practice I've adhered to for my Regardless, I think the modification within the commit I just made brings it back to a cleaner state while still retaining the usage organization. Let me know if this change works for you. |
|
@nick-w-nick yes! that change is more clean for me... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, in this PR I've gone ahead and cleaned up/reorganized the
app.jsfile.The changes include:
body-parserwith the built-in express middlewarehelmetmiddleware which grants automatic generic security policiesI'm planning to apply this structure to the rest of the codebase in future commits but thought I'd start with the root of the application initially.
Let me know if you need any changes/etc.
Thanks!