Repository navigation
fix: keep terminal helper script alive until child exits - #288
Open
alexsmolya wants to merge 1 commit into
Open
alexsmolya wants to merge 1 commit into
alexsmolya wants to merge 1 commit into
Conversation
Author
|
I'm continuing this work as a partner, not as a competitor. The existing terminal-helper fix and its investigation may provide useful evidence, so I want to preserve and validate that work rather than throw it away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
terminal-helperdeletes the generated temporary script after the terminal launcher returns, butkgx --waitdoes not guarantee that delayedpkexec/bash has already consumed it. This can produce failures such asbash: /tmp/tmp...: No such file or directory.This change:
The tests use harmless marker commands only; no real root, package, or system mutation is used.
Validation:
bash -n src/scripts/terminal-helper src/scripts/rootshell.sh tests/terminal-helper_test.shtests/terminal-helper_test.shgit diff --checkFixes #287