Skip to content

fix: break circular layout dependency causing RecycleView infinite loop (fixes #124) #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RockyOmvi wants to merge 1 commit into
base: font_setting
Choose a base branch
from
Open

fix: break circular layout dependency causing RecycleView infinite loop (fixes #124) #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 2 additions & 42 deletions src/buskill.kv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,29 +343,14 @@
# size: self.size

<BusKillOptionItem>:
size_hint: .25, None
size_hint: 1, None
height: labellayout.height + dp(10)
padding: 6
spacing: 5

icon_label: icon_label
radio_button_label: radio_button_label

# uncomment to debug boundaries
# canvas:
# Color:
# #rgba: 47 / 255., 167 / 255., 212 / 255., self.selected_alpha
# #rgba: 0, 1, 0, 1
# rgba: (0, 1, 0, 1 if DEBUG == True else 0, 0, 0, 0)
# Rectangle:
# pos: self.x, self.y + 1
# size: self.size
# Color:
# rgb: .2, .2, .2
# Rectangle:
# pos: self.x, self.y - 2
# size: self.width, 1

StackLayout:
pos: root.pos
orientation: 'lr-tb'
Expand All @@ -375,52 +360,27 @@
Label:
id: radio_button_label
markup: True
#text: ('[font=mdicons][size=18sp]\ue837[/size][/font] ' if root.parent_option.value == root.value else '[font=mdicons][size=18sp]\ue836[/size][/font] ')
#text: '[font=mdicons][size=18sp]\ue837[/size][/font] '
text: root.radio_button_icon
size: self.texture_size
size_hint: None, None
height: labellayout.height
#height: dp(300)

# uncomment to debug boundaries
# canvas.before:
# Color:
# rgba: 1, 0, 0, 1
# Rectangle:
# pos: self.pos
# size: self.size

Label:
id: icon_label
markup: True
text: ('[font=mdicons][size=40sp][color=ffffff00]\ue256[/color][/size][/font]' if root.icon == None else '[font=mdicons][size=40sp]' +root.icon+ '[/size][/font]')
size: self.texture_size
size_hint: None, None
height: labellayout.height
#height: dp(300)

# uncomment to debug boundaries
# canvas.before:
# Color:
# rgba: 0, 0, 1, 1
# Rectangle:
# pos: self.pos
# size: self.size

Label:
id: labellayout
markup: True
text: u'{0}\n[size=13sp][color=999999]{1}[/color][/size]'.format(root.option_human or root.value or '', root.desc or '')
font_size: '15sp'
text_size: root.width - icon_label.width - radio_button_label.width - (2*root.padding) - (2*root.spacing), None
text_size: root.width - dp(100), None
size: self.texture_size
size_hint: None, None

# set the minimum height of this item so that fat fingers don't have
# issues on small touchscreen displays (for better UX)
height: max(self.height, dp(80))
#height: dp(1000)

# uncomment to debug boundaries
# canvas.before:
Expand Down
5 changes: 2 additions & 3 deletions src/buskill_gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,9 +916,8 @@ def update_data(self):
# set the radio button icon to "unselected"
self.rv.data[n]['radio_button_icon'] = '[font=mdicons][size=18sp]\ue836[/size][/font] '

# update RecycleView data in next frame
# * https://stackoverflow.com/questions/49935190/kivy-how-to-initialize-the-viewclass-of-the-recycleview-dynamically
Clock.schedule_once(self.rv.refresh_from_data,0)
# trigger RecycleView refresh by replacing data list
self.rv.data = list(self.rv.data)
Comment on lines +919 to +920

# This is our main Screen when the user clicks "Settings" in the nav drawer
class BusKillSettingsScreen(Screen):
Expand Down
Loading