Skip to content

Re-record serverless function-size baselines to current fleet sizes - #5057

Merged
steve8708 merged 3 commits into
mainfrom
steve8708/changes-8110
Sep 15, 2026
Merged

steve8708 merged 3 commits into
mainfrom
steve8708/changes-8110

Conversation

@steve8708

Copy link
Copy Markdown
Contributor

What changed

Raises 16 recorded values in scripts/serverless-function-baseline.json (server and server-agent-background for assets, content, slides, forms, analytics, calendar, plan, dispatch) to the sizes CI measures today. No code changes.

Why

The Assets PR preview build on #5020 failed the function-size guard at 56.0MB against a 50.9MB baseline (tolerance 55.99MB), a 0.01MB miss. A local rebuild of the exact pre-merge and post-merge commits shows that PR added only 38KB; the ~5MB step is fleet-wide and predates it: the deploy copies 13 browser runtime packages into every server bundle for Creative Context (#4953) and the baselines were never re-recorded. #5028 nudged assets to 51.2MB, which leaves assets and content within 0.1MB of tolerance and slides within 0.8MB, so any small core change trips the guard on those previews again.

How the numbers were derived

Each value is the size printed by the build in run 34972925847 (Deploy Netlify PR previews, branch changes-8103), rounded up to the byte from the logged MB. Sites with no baseline (starter, fw, design) are unchanged. clips and mail are unchanged because their recorded baselines are far above their preview-lane sizes and may reflect the beta lane; lowering them without a beta measurement could break that deploy.

Follow-up worth a decision

Creative Context is an opt-in Lab, yet its 13 browser runtime packages (~5MB) ride in every site's server function and are unzipped on every cold start. Copying them only for sites that enable the Lab would remove the growth instead of accepting it.

Eight sites (assets, content, slides, forms, analytics, calendar, plan, dispatch) had outgrown their recorded server and server-agent-background baselines; assets and content sat within 0.1MB of the 10% tolerance, which is why PR #5020's Assets preview build failed the guard by 0.01MB and why #5028's small bump barely cleared it. The step is fleet-wide and already accepted: the deploy copies 13 browser runtime packages into every server bundle for Creative Context (#4953), and that was never re-recorded.

Values are the sizes measured by CI in run 34972925847 (Deploy Netlify PR previews, changes-8103), rounded up to the byte from the logged MB, so future growth is measured from where each app actually is. clips and mail are left alone: their recorded baselines are far above their preview-lane sizes and may reflect the beta lane, so lowering them without a beta measurement could break that deploy.
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Incremental Code Review Summary

The latest PR head retains the intended 16 serverless baseline updates and adds only a terminal newline to an existing changelog markdown file. The baseline JSON remains valid, preserves the existing site/function schema, and contains safe integer byte counts matching the stated CI measurements. The changelog content and frontmatter are semantically unchanged.

Two independent incremental reviews found no new confirmed issues. Focused baseline tests pass, and the newline-only markdown change has no packaging, localization, or user-facing behavior impact. There were no previous findings to resolve or re-submit.

Risk assessment

Low risk: configuration/baseline data plus a formatting-only markdown change.

Findings

No new actionable findings.

🧪 Browser testing: Skipped — the only content-file change is newline-only and there is no UI behavior impact

@steve8708
steve8708 merged commit e762557 into main Sep 15, 2026
48 checks passed
@steve8708
steve8708 deleted the steve8708/changes-8110 branch September 15, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant