Goal condition

[jaydencarlson05]

Description

The function of assuming a solution for a given puzzle was clunky, so it has been removed. The running implementation will view the puzzle having no solution as a logical contradiction, thus making it a valid proof for any condition. Also fixed some strange goal condition messages when dealing with PROVE_VALUES_ARE_POSSIBLE.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Enhancement (improvement to an already existing feature)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Existing tests for the goal conditions have been updated/deleted to fit the new definition of a valid proof. A couple puzzle files were checked to make sure everything was in working order. The proof editor also still works as intended.

Checklist:

• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (if applicable)
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes