Revive or remove the last non-manual skipped tests - #8347
Merged
Conversation
andrew-polk
commented
Sep 11, 2026
Contributor
Author
Contributor
Author
|
[Claude Fable] Consulted Devin on 2026-09-11 00:24 UTC up to commit 8725736. No bugs. One new Investigate flag (the icon test read the inline style), mirrored as a review thread and fixed in 1324dee; the other two flags were repeats already fixed in the reviewed commit. No informational flags. Re-review of 1324dee follows. |
Contributor
Author
|
[Claude Fable] Consulted Devin on 2026-09-11 00:26 UTC up to commit 1324dee. Re-review clean: no bugs, and its three Investigate flags are repeats of findings already fixed in the reviewed commits (the icon test now reads data-icon-src, checks for a real image, and documents its wait). No informational flags. |
After #8311 the nightly still reported six skipped C# tests and one skipped React component test, all long-ignored with stale reasons. Each is revived or removed by what the reason turned out to mean. - HtmlDomTests: the two plus-sign GetImageElementUrl tests run again. The code was right; UrlPathString treats '+' as a literal plus and encodes it as %2b (BL-3259), so one expectation is corrected. - XmlHtmlConverterTests: the em-next-to-strong test now sets PreserveWhitespace before loading, as BookStorage does for every real book (BL-2484), and passes. A live Bloom confirmed the app never had the bug; BL-16858 records why BL-2558 was unreproducible. - Deleted BookTests.CanDelete_TemplateBook_False (deletability has not depended on templateness since BL-2678) and the two BookStarterTests Vaccinations cover tests (cover image and topic are Book's job, not BookStarter's). - ToolboxRoot component test: the fixme is a real test. The header icon span carries a test id and data-icon-src, the subscription badge carries a test id, and the test asserts on those rather than on computed styles. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
andrew-polk
force-pushed
the
reinstate-skipped-tests
branch
from
September 11, 2026 04:09
1324dee to
af3b370
Compare
andrew-polk
marked this pull request as ready for review
September 11, 2026 04:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. After #8311 the nightly still reported six skipped C# tests and one skipped React component test. All seven were long-ignored tests whose reasons had gone stale, so the count kept hiding whether anything real was skipped.
Fix. Each is either revived or removed, by what the ignore reason turned out to mean:
+as a literal plus and encodes it as%2b(BL-3259). One expectation changed; both run again.PreserveWhitespace, a shape production never saves, so the indenting writer split the two inline elements. Every real book is loaded withPreserveWhitespaceon (BookStorage, BL-2484). The test now does the same and passes. Confirmed in a live Bloom that the app never had the bug, which is why BL-2558 was unreproducible; BL-16858 records that.Expected on the next nightly: C# and React component skips both go to 0.
🤖 Generated with Claude Code
Devin review
This change is