Refuse to build an app from a Playground book (BL-16855) - #8344
Closed
andrew-polk wants to merge 1 commit into
Closed
Refuse to build an app from a Playground book (BL-16855)#8344andrew-polk wants to merge 1 commit into
andrew-polk wants to merge 1 commit into
Conversation
andrew-polk
commented
Sep 10, 2026
Contributor
Author
|
[Claude Fable 5.1] Consulted Devin on 2026-09-10 22:02 UTC up to commit |
https://issues.bloomlibrary.org/youtrack/issue/BL-16855 Publish > Apps was the one publish screen that did not refuse a book made from the Playground template. The Reading App Builder status now lists the titles of any Playground books among the books headed into the app (every tracked book, not just the current one); the Apps screen disables Prepare and Build while that list is non-empty, with a tooltip naming the books. The export also refuses to start if any such book is present, naming it in the log. IsPlayground moves to BookInfo so both checks read the lineage without loading the book, and a tracked book that was deleted from the collection is skipped by the status rather than breaking it. Tests: RabPlaygroundCheckTests and an appBuilderShared spec; full C# and vitest suites green. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
andrew-polk
force-pushed
the
BL-16855
branch
from
September 10, 2026 22:23
eca3717 to
52d5de4
Compare
andrew-polk
marked this pull request as ready for review
September 10, 2026 22:23
Member
|
That's alot of code for this one check, isn't it? I wonder if we could trade bullet-proofness for something simpler, such as simply filtering them out in the chooser? |
andrew-polk
marked this pull request as draft
September 11, 2026 16:27
Contributor
Author
|
[Claude Fable 5.1] Closing: superseded by #8348, which fixes BL-16855 by showing the Publish > Apps subscription overlay for a Playground book instead of disabling Prepare and Build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. Bloom refuses to publish a book made from the Playground template: the BloomPUB, ePUB, PDF, video, and library-upload screens all disable their action button for such a book. Publish > Apps (Reading App Builder) was the exception, so a Playground book could be turned into an Android app.
What the PR does.
Ref: https://issues.bloomlibrary.org/youtrack/issue/BL-16855
🤖 Generated with Claude Code
Devin review
This change is