Keep Bloom's log and collection when an e2e test fails, and harden two new tests - #8343
Merged
Conversation
…o new tests A failed test now leaves Bloom's Log.txt and a copy of its collection folder in test-results, which the nightly already uploads. Three nightly failures since 5 September lost a cover title that the test saw typed; the book's HTML on disk will say which side lost it. The user-settings folder is not kept: the artifact is public and user.config holds a real Bloom Library login. user-settings-isolation read user.config while Bloom held it (EBUSY on the runner); the reader now retries a busy file. The font chooser's information icon re-renders under the mouse (unstable, then detached, for a whole click attempt); the click is now retried against the icon as it currently is. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
[Claude Fable 5.1] Consulted Devin on 2026-09-10 21:49 UTC up to commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. The nightly BloomE2E run has been red every night since 4 September. The recurring failures were fixed on 9 September, but the 10 September run brought four new ones. Two are ordinary timing flakes in tests added on 8 September: reading
user.configwhile Bloom held it open (EBUSY), and a click on the font chooser's information icon that timed out because the popover kept re-rendering. The other two are a problem nobody can yet explain: a title typed on a new book's cover never reaches the collection, so the test cannot find its book. That has now hit three different specs on three nights and has never reproduced on a developer machine. All the nightly leaves behind is Playwright's trace and a screenshot, which show what the test saw but not what Bloom saved.What the PR does.
Log.txtand a copy of the collection folder as Bloom left it, in thetest-resultsfolder the nightly already uploads. The next lost-title failure will show whether the title is in the book's HTML on disk or was never saved. The user-settings folder is deliberately not kept: the artifact is public anduser.configholds a real Bloom Library login after the sign-in tests.user.configfor a few seconds instead of throwing.Devin review
This change is