Skip to content

Smoke test fix #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AnonymousWalker wants to merge 1 commit into from
Closed

Smoke test fix #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared/src/commonMain/kotlin/org/bibletranslationtools/writer/ui/settings/SettingsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ fun SettingsScreen(
)
}
) { paddingValues ->
LazyColumn(contentPadding = paddingValues) {
LazyColumn(modifier = Modifier.padding(paddingValues)) {

// --- GENERAL PREFERENCES ---
item { PreferenceCategoryHeader(stringResource(Res.string.header_general)) }
Expand Down
21 changes: 17 additions & 4 deletions shared/src/jvmTest/kotlin/org/bibletranslationtools/writer/uitest/SmokeFlow.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.bibletranslationtools.writer.uitest

import androidx.compose.ui.semantics.SemanticsActions
import androidx.compose.ui.test.ComposeUiTest
import androidx.compose.ui.test.ExperimentalTestApi
import androidx.compose.ui.test.assertIsDisplayed
Expand All @@ -10,6 +11,7 @@ import androidx.compose.ui.test.onAllNodesWithText
import androidx.compose.ui.test.onNodeWithContentDescription
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.performClick
import androidx.compose.ui.test.performSemanticsAction
import androidx.compose.ui.test.performTextInput
import androidx.compose.ui.test.performTextReplacement
import androidx.compose.ui.test.performTouchInput
Expand Down Expand Up @@ -40,13 +42,13 @@ fun ComposeUiTest.completeSmokeSettings() {
scrollUntilVisible("I Agree")
onNodeWithText("I Agree").performClick()

waitUntilVisible("Your Translation Projects", timeoutMillis = 3_000)
waitUntilVisible("Your Translation Projects", timeoutMillis = 15_000)

onNodeWithContentDescription("More Options").performClick()
onNodeWithText("Settings").performClick()

onNodeWithText("General").assertIsDisplayed()
onNodeWithContentDescription("back").performClick()
waitUntilVisible("General", timeoutMillis = 10_000)
tapBack()
waitUntilVisible("Your Translation Projects", timeoutMillis = 15_000)
}

Expand Down Expand Up @@ -115,7 +117,7 @@ fun ComposeUiTest.completeSmokeProjectMenu() {
onNodeWithText("John - Ghotuo", substring = true).assertIsDisplayed()
onNodeWithContentDescription("Publish").performClick()
onNodeWithText("Publish translation").assertIsDisplayed()
onNodeWithContentDescription("back").performClick()
tapBack()
waitUntilVisible("Your Translation Projects", timeoutMillis = 5_000)

onNodeWithContentDescription("Info").performClick()
Expand All @@ -141,6 +143,17 @@ private fun ComposeUiTest.tapIfVisible(
}
}

/**
* [performClick] injects a pointer event and relies on hit-testing. Screens that use
* Scaffold + LazyColumn(contentPadding) keep a full-size scrollable under the top app bar,
* which can swallow the coordinate click in headless Compose UI tests. Invoking the
* semantics OnClick action bypasses hit-testing.
*/
@OptIn(ExperimentalTestApi::class)
private fun ComposeUiTest.tapBack() {
onNodeWithContentDescription("back").performSemanticsAction(SemanticsActions.OnClick)
}

@OptIn(ExperimentalTestApi::class)
private fun ComposeUiTest.scrollUntilVisible(text: String, timeoutMillis: Long = 5_000) {
val deadline = System.nanoTime() + timeoutMillis * 1_000_000L
Expand Down
Loading