Separate mac builds to ARM64 and Intel - #346
Open
mXaln wants to merge 3 commits into
Open
Conversation
Drops the universal build (and its osxUniversal x64ArchFiles config), so no Intel Mac artifact is produced anymore.
volume names over 27 chars and the versioned file name exceeds that. Drop zip artifacts
binary; the release step builds them sequentially since appdmg mounts a volume per dmg.
PurpleGuitar
approved these changes
Aug 12, 2026
|
|
||
| Promise.all(platforms.map(packagePlatform)) | ||
| .then(() => done()) | ||
| .catch(err => { |
Collaborator
There was a problem hiding this comment.
Currently, this catch() will log the error and then call done(), allowing the build to continue. I think we should consider erroring out instead so that we don't accidentally (and silently) release a broken build.
| } | ||
| }); | ||
|
|
||
| Promise.all(tasks).then(() => done()); |
Collaborator
There was a problem hiding this comment.
Not part of your change, but again I think we should consider catching errors here and failing the build.
| const options = { | ||
| appPath: buildPath, | ||
| name: name, | ||
| title: APP_NAME, |
Collaborator
There was a problem hiding this comment.
If you made the title APP_NAME + "-" + ${arch}, would that remove the need for the "tricky" code below? It might let you run the builds in parallel too.
| throw new Error('Missing build'); | ||
| } | ||
|
|
||
| const linuxDest = `${RELEASE_DIR}BTT-Writer-${packageJson.version}-linux-x64.zip`; |
Collaborator
There was a problem hiding this comment.
Can we keep the Linux .zip download? The .deb target only works for Debian-based Linux targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes in this pull request: