Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Contracts/DataModels.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ export interface DatabaseAccountExtendedProperties {
enablePriorityBasedExecution?: boolean;
vcoreMongoEndpoint?: string;
enableAllVersionsAndDeletesChangeFeed?: boolean;
enableFullFidelityChangeFeed?: boolean;
enableEmbeddingGenerator?: boolean;
}

export interface DatabaseAccountResponseLocation {
Expand Down Expand Up @@ -414,6 +416,7 @@ export interface AccountOverride {
capacityMode?: CapacityMode;
enableFreeTier?: boolean;
enableAnalyticalStorage?: boolean;
enableEmbeddingGenerator?: boolean;
}

export interface CreateDatabaseParams {
Expand Down Expand Up @@ -458,6 +461,15 @@ export interface VectorEmbedding {
dimensions: number;
distanceFunction: "euclidean" | "cosine" | "dotproduct";
path: string;
embeddingSource?: VectorEmbeddingSource;
}

export interface VectorEmbeddingSource {
sourcePaths: string[];
deploymentName: string;
modelName: string;
endpoint: string;
authType: "Entra";
}

export interface FullTextPolicy {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export interface CollapsibleSectionProps {
onDelete?: () => void;
disabled?: boolean;
disableDelete?: boolean;
dataTest?: string;
}

export interface CollapsibleSectionState {
Expand Down Expand Up @@ -57,6 +58,7 @@ export class CollapsibleSectionComponent extends React.Component<CollapsibleSect
tabIndex={0}
role="button"
aria-expanded={this.state.isExpanded}
data-test={this.props.dataTest}
>
<Icon iconName={this.state.isExpanded ? "ChevronDown" : "ChevronRight"} />
<Label styles={{ root: { color: "var(--colorNeutralForeground1)" } }}>{this.props.title}</Label>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,14 @@ import "@testing-library/jest-dom";
import { RenderResult, fireEvent, render, screen, waitFor } from "@testing-library/react";
import { VectorEmbedding, VectorIndex } from "Contracts/DataModels";
import React from "react";
import * as CapabilityUtils from "Utils/CapabilityUtils";
import { VectorEmbeddingPoliciesComponent } from "./VectorEmbeddingPoliciesComponent";

// The embedding-source UI is gated behind the integrated-embedding capability.
// Default the mock to `true` for the existing suites so they exercise the full UI;
// the dedicated suite at the bottom of this file flips it to `false` to verify gating.
jest.spyOn(CapabilityUtils, "isIntegratedEmbeddingEnabled").mockReturnValue(true);

const mockVectorEmbedding: VectorEmbedding[] = [
{ path: "/vector1", dataType: "float32", distanceFunction: "euclidean", dimensions: 0 },
];
Expand Down Expand Up @@ -81,3 +87,197 @@ describe("AddVectorEmbeddingPolicyForm", () => {
});
});
});

describe("VectorEmbeddingPoliciesComponent - embedding source", () => {
const newEmbedding: VectorEmbedding[] = [
{ path: "/vector2", dataType: "float32", distanceFunction: "cosine", dimensions: 1536 },
];
let onChange: jest.Mock;
let view: RenderResult;

beforeEach(() => {
onChange = jest.fn();
view = render(
<VectorEmbeddingPoliciesComponent
vectorEmbeddingsBaseline={[]}
vectorEmbeddings={newEmbedding}
vectorIndexes={[]}
onVectorEmbeddingChange={onChange}
/>,
);
});

const expandSection = () => {
const header = screen.getByRole("button", { name: /Embedding source/ });
fireEvent.click(header);
};

test("renders the embedding source accordion collapsed by default with no errors", () => {
expect(screen.getByText("Embedding source (Preview)")).toBeInTheDocument();
expect(view.container.querySelector("#vector-policy-embeddingSource-sourcePaths-1")).toBeNull();
const lastCall = onChange.mock.calls[onChange.mock.calls.length - 1];
expect(lastCall[2]).toBe(true);
expect(lastCall[0][0].embeddingSource).toBeUndefined();
});

test("expanding the accordion reveals all source fields without errors when empty", () => {
expandSection();
expect(view.container.querySelector("#vector-policy-embeddingSource-sourcePaths-1")).not.toBeNull();
expect(view.container.querySelector("#vector-policy-embeddingSource-deploymentName-1")).not.toBeNull();
expect(view.container.querySelector("#vector-policy-embeddingSource-modelName-1")).not.toBeNull();
expect(view.container.querySelector("#vector-policy-embeddingSource-endpoint-1")).not.toBeNull();
expect(view.container.querySelector("#vector-policy-embeddingSource-authType-1")).not.toBeNull();
expect(screen.queryByText("At least one source path is required")).toBeNull();
expect(screen.queryByText("Deployment name is required")).toBeNull();
});

test("typing in one field surfaces required errors for the others", async () => {
expandSection();
fireEvent.change(view.container.querySelector("#vector-policy-embeddingSource-deploymentName-1"), {
target: { value: "my-deployment" },
});
await waitFor(() => {
expect(screen.getByText("At least one source path is required")).toBeInTheDocument();
expect(screen.getByText("Model name is required")).toBeInTheDocument();
expect(screen.getByText("Endpoint is required")).toBeInTheDocument();
});
const last = onChange.mock.calls[onChange.mock.calls.length - 1];
expect(last[2]).toBe(false);
});

test("invalid endpoint shows the https:// error", async () => {
expandSection();
fireEvent.change(view.container.querySelector("#vector-policy-embeddingSource-endpoint-1"), {
target: { value: "not-a-url" },
});
await waitFor(() => expect(screen.getByText("Endpoint must be a valid https:// URL")).toBeInTheDocument());

fireEvent.change(view.container.querySelector("#vector-policy-embeddingSource-endpoint-1"), {
target: { value: "http://insecure.example.com" },
});
await waitFor(() => expect(screen.getByText("Endpoint must be a valid https:// URL")).toBeInTheDocument());
});

test("valid input propagates an embeddingSource with parsed sourcePaths", async () => {
expandSection();
fireEvent.change(view.container.querySelector("#vector-policy-embeddingSource-sourcePaths-1"), {
target: { value: "/description, title" },
});
fireEvent.change(view.container.querySelector("#vector-policy-embeddingSource-deploymentName-1"), {
target: { value: "my-deployment" },
});
fireEvent.change(view.container.querySelector("#vector-policy-embeddingSource-modelName-1"), {
target: { value: "text-embedding-3-small" },
});
fireEvent.change(view.container.querySelector("#vector-policy-embeddingSource-endpoint-1"), {
target: { value: "https://my-foundry.openai.azure.com" },
});

await waitFor(() => {
const lastCall = onChange.mock.calls[onChange.mock.calls.length - 1];
const [embeddings, , valid] = lastCall;
expect(valid).toBe(true);
expect(embeddings[0].embeddingSource).toEqual({
sourcePaths: ["/description", "/title"],
deploymentName: "my-deployment",
modelName: "text-embedding-3-small",
endpoint: "https://my-foundry.openai.azure.com",
authType: "Entra",
});
});
});

test("clearing all fields drops embeddingSource from the emitted embedding", async () => {
expandSection();
const sourcePaths = view.container.querySelector(
"#vector-policy-embeddingSource-sourcePaths-1",
) as HTMLInputElement;
const deploymentName = view.container.querySelector(
"#vector-policy-embeddingSource-deploymentName-1",
) as HTMLInputElement;
const modelName = view.container.querySelector("#vector-policy-embeddingSource-modelName-1") as HTMLInputElement;
const endpoint = view.container.querySelector("#vector-policy-embeddingSource-endpoint-1") as HTMLInputElement;

fireEvent.change(sourcePaths, { target: { value: "/description" } });
fireEvent.change(deploymentName, { target: { value: "d" } });
fireEvent.change(modelName, { target: { value: "m" } });
fireEvent.change(endpoint, { target: { value: "https://x.example.com" } });

await waitFor(() => {
const lastCall = onChange.mock.calls[onChange.mock.calls.length - 1];
expect(lastCall[2]).toBe(true);
expect(lastCall[0][0].embeddingSource).toBeDefined();
});

fireEvent.change(sourcePaths, { target: { value: "" } });
fireEvent.change(deploymentName, { target: { value: "" } });
fireEvent.change(modelName, { target: { value: "" } });
fireEvent.change(endpoint, { target: { value: "" } });

await waitFor(() => {
const lastCall = onChange.mock.calls[onChange.mock.calls.length - 1];
const [embeddings, , valid] = lastCall;
expect(valid).toBe(true);
expect(embeddings[0].embeddingSource).toBeUndefined();
});
});

test("does not loop onVectorEmbeddingChange once all fields become valid (regression)", async () => {
// Regression for an infinite render loop where the child rebuilt a fresh
// VectorEmbeddingSource literal on every render, defeating the parent's
// reference-equality dedupe and re-triggering child useEffect via the
// unstable onChange prop. Before the fix, this scenario hung the test
// runner (Jest would time out after several minutes).
expandSection();
fireEvent.change(view.container.querySelector("#vector-policy-embeddingSource-sourcePaths-1"), {
target: { value: "/title, /description" },
});
fireEvent.change(view.container.querySelector("#vector-policy-embeddingSource-deploymentName-1"), {
target: { value: "text-embedding-ada-002" },
});
fireEvent.change(view.container.querySelector("#vector-policy-embeddingSource-modelName-1"), {
target: { value: "text-embedding-ada-002" },
});
fireEvent.change(view.container.querySelector("#vector-policy-embeddingSource-endpoint-1"), {
target: { value: "https://my-foundry.openai.azure.com" },
});

await waitFor(() => {
const lastCall = onChange.mock.calls[onChange.mock.calls.length - 1];
expect(lastCall[2]).toBe(true);
expect(lastCall[0][0].embeddingSource).toBeDefined();
});

const stable = onChange.mock.calls.length;
await new Promise((resolve) => setTimeout(resolve, 100));
expect(onChange.mock.calls.length).toBe(stable);
});
});

describe("VectorEmbeddingPoliciesComponent - embedding source gating", () => {
const newEmbedding: VectorEmbedding[] = [
{ path: "/vector3", dataType: "float32", distanceFunction: "cosine", dimensions: 1536 },
];

test("hides the embedding source accordion when the integrated-embedding capability is missing", () => {
const isEnabledSpy = jest.spyOn(CapabilityUtils, "isIntegratedEmbeddingEnabled").mockReturnValue(false);
try {
const view = render(
<VectorEmbeddingPoliciesComponent
vectorEmbeddingsBaseline={[]}
vectorEmbeddings={newEmbedding}
vectorIndexes={[]}
onVectorEmbeddingChange={jest.fn()}
/>,
);
expect(screen.queryByText("Embedding source (Preview)")).toBeNull();
expect(view.container.querySelector("#vector-policy-embeddingSource-sourcePaths-1")).toBeNull();
expect(view.container.querySelector("#vector-policy-embeddingSource-deploymentName-1")).toBeNull();
expect(view.container.querySelector("#vector-policy-embeddingSource-modelName-1")).toBeNull();
expect(view.container.querySelector("#vector-policy-embeddingSource-endpoint-1")).toBeNull();
expect(view.container.querySelector("#vector-policy-embeddingSource-authType-1")).toBeNull();
} finally {
isEnabledSpy.mockReturnValue(true);
}
});
});
Loading
Loading