Skip to content

fix(ci): budget the root-rollup VK test to its measured cost, drop a redundant circuit copy #25127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AztecBot wants to merge 2 commits into
base: next
Choose a base branch
from
+8 −3
Draft

fix(ci): budget the root-rollup VK test to its measured cost, drop a redundant circuit copy #25127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7f7e7d
fix(ci): give root-rollup VK test a timeout budget that fits its runtime
AztecBot Aug 6, 2026
9f1c754
update PR #25127
AztecBot Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions barretenberg/cpp/bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,11 @@ function test_cmds_native {
prefix="$prefix:CPUS=8:MEM=16g"
elif [[ "$test" == HonkRecursionConstraintTestWithoutPredicate/2.* ]]; then
# Root rollup circuit (HonkRecursionTypesWithoutPredicate index 2, IsRootRollup=true):
# a ~6.35M-gate circuit whose VK generation is memory- and compute-heavy.
prefix="$prefix:CPUS=8:MEM=16g"
# a ~6.35M-gate circuit whose VK generation is memory- and compute-heavy. It peaks at
# ~19.2GiB RSS and, because parallelize runs nproc/2 jobs that each take HARDWARE_CONCURRENCY
# threads, its wall-time spreads ~5x with host load (102s..486s observed on a healthy 64-core
# runner). The default 600s budget leaves no headroom for the slow tail, so give it 20m.
prefix="$prefix:CPUS=8:MEM=20g:TIMEOUT=20m"
elif [[ "$test" =~ ^(AcirAvmRecursionConstraint|ChonkKernelCapacity|AvmRecursiveTests|IPARecursiveTests|HonkRecursionConstraintTest|ChonkRecursionConstraintTest) ]]; then
# IPARecursiveTests fails with 2 threads.
prefix="$prefix:CPUS=4:MEM=8g"
Expand Down
4 changes: 3 additions & 1 deletion barretenberg/cpp/src/barretenberg/dsl/acir_format/test_class.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,9 +688,11 @@ template <TestBase Base_> class TestClass {
{
AcirProgram program{ constraint_system, witness_values };
auto builder = create_circuit<Builder>(program, Base::generate_metadata());
num_gates = builder.get_num_finalized_gates_inefficient();

auto prover_instance = std::make_shared<ProverInstance>(builder);
// Constructing the ProverInstance finalizes the builder, so the gate count is available here
// without get_num_finalized_gates_inefficient()'s copy of the whole circuit.
num_gates = builder.get_num_finalized_gates();
vk_from_witness = std::make_shared<VerificationKey>(prover_instance->get_precomputed());

// Validate the builder
Expand Down
Loading