add: Cellular Network support - #2765
Conversation
| "%1 issue found", | ||
| "%1 issues found", | ||
| "%1 min left", | ||
| "%1 modem, none connected", |
There was a problem hiding this comment.
This file existed as a means to dis-allow new translations during a temporary freeze period, should not be edited in PRs. Its deleted on master now though so its a moot point, should rebase the PR
| @@ -7,6 +7,9 @@ type Backend interface { | |||
| GetWiFiEnabled() (bool, error) | |||
There was a problem hiding this comment.
Would like to see server.go APIVersion incremented, trivial though
| "icon": "dashboard" | ||
| }, | ||
| { | ||
| "section": "_tab_44", |
There was a problem hiding this comment.
This file is generated with script extract_settings_index.py , that should be ran to re-generate it
| connectionError = response.error; | ||
| lastConnectionError = response.error; | ||
| connectionStatus = "failed"; | ||
| ToastService.showError(I18n.tr("Failed to activate cellular connection"), response.error); |
There was a problem hiding this comment.
I thtink theres in general too many new translation terms here, I'd re-use whatever you can where its applicable.
|
@yechielw Linked related issue |
|
Rebased onto current Updated work is in #3096 — I don't have write access to this fork's |
3 participants
Description
This PR was writin completly by codex
I have bean using it for a couple of weeks and it works perfect
it includs celluler options in quick settings, celluler indicator in the widget and celluler tab in the settings app
Type of change
Related issues
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings