Skip to content

Created two cmd line utilities for converting between hex and json - #16

Merged
ericpassmore merged 14 commits into
AntelopeIO:mainfrom
ericpassmore:main
Nov 14, 2024
Merged

ericpassmore merged 14 commits into
AntelopeIO:mainfrom
ericpassmore:main

Conversation

@ericpassmore

Copy link
Copy Markdown
Contributor

Created two command line programs

  • generate_hex_from_json - creates hex given an ABI and JSON
  • generate_json_from_hex - creates json when provided an ABI and hex encoding

Used this for generating test data for eosjs

@ericpassmore ericpassmore self-assigned this Jan 21, 2023
@heifner

heifner commented Jan 21, 2023

Copy link
Copy Markdown
Contributor

I think something more like EOSIO/abieos#60 where the abi is provided as an abi file would be better.

@ericpassmore

Copy link
Copy Markdown
Contributor Author

I think something more like EOSIO/abieos#60 where the abi is provided as an abi file would be better.

Good example, I can switch to a file to ABI, and I move the executables to tools directory.

Ok to use c++ to read the file? Specifically using std::filesystem::file_size for the file size, preallocating a byte vector, std::ifstream::read to populate the vector, then converting to string? The C-style malloc/free isn't my favorite.

@heifner

heifner commented Jan 23, 2023

Copy link
Copy Markdown
Contributor

I think same location of executes as name is good.
Yes, please use C++ instead of C constructs for this including cout/cerr over fprintf.

@spoonincode

Copy link
Copy Markdown
Contributor

fwiw a small, simple, but inefficient way I've used to read in a small file to a string is something like

   std::string filename = "foo.file";
   std::ifstream ifs(filename);
   std::string string_of_file_contents((std::istreambuf_iterator<char>(ifs)), std::istreambuf_iterator<char>());

(inefficiency doesn't really matter for simple stuff like this)

@ericpassmore

Copy link
Copy Markdown
Contributor Author

I think same location of executes as name is good. Yes, please use C++ instead of C constructs for this including cout/cerr over fprintf.

Got it, I will C++'ify the code. Thanks for the simple approach to reading a small file. I'll take it.

Comment thread tools/test_utils.sh Outdated
Comment thread tools/util_generate_hex_from_json.cpp Outdated
Comment thread tools/CMakeLists.txt Outdated
Comment thread tools/util_generate_hex_from_json.cpp Outdated
Comment thread tools/util_generate_hex_from_json.cpp Outdated
Comment thread tools/util_generate_hex_from_json.cpp Outdated
Comment thread tools/util_generate_json_from_hex.cpp
Comment thread tools/util_generate_hex_from_json.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants