Repository navigation
Refactor NotificationToggleBox to handle permission changes on focus … - #768
Open
WouterAms wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the notification-permission retry changes.
No open issues 🎉
What changed in this PR
Refactors NotificationToggleBox to retry notification permission handling when the screen regains focus after opening permission instructions.
Changes:
- Distinguishes switch presses from focus-triggered retries.
- Tracks pending retries and clears them after permission checks or errors.
- Connects retry handling to the navigation focus lifecycle.
| File | Description |
|---|---|
src/components/features/NotificationToggleBox.tsx |
Adds focus-based permission retries and separate handling for switch presses. |
Review effort: Balanced
WouterAms
enabled auto-merge
November 13, 2026 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and press events
Changes
Refactors
NotificationToggleBoxto retry notification permission handling when the screen regains focus after opening permission instructions.Changes:
src/components/features/NotificationToggleBox.tsxTest instructions
Other notes