Repository navigation
Conversation
github-actions
Bot
added
the
module:boat-charging
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the charging-duration refresh change.
No open issues 🎉
What changed in this PR
Updates the boat-charging session provider so charging-duration strings refresh after each successful data refetch, even when the session data is unchanged.
Changes:
- Adds
fulfilledTimeStampto the memoization dependencies. - Adds a scoped lint suppression for the intentional extra dependency.
| File | Description |
|---|---|
| src/modules/boat-charging/providers/BoatChargingSession.provider.tsx | Recomputes duration strings when refetched data arrives. |
Review effort: Balanced
WouterAms
enabled auto-merge
November 13, 2026 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updates the boat-charging session provider so charging-duration strings refresh after each successful data refetch, even when the session data is unchanged.
Changes:
fulfilledTimeStampto the memoization dependencies.Test instructions
Other notes