-
Notifications
You must be signed in to change notification settings - Fork 157
refactor: align UI with shadcn and clear audit findings #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AmintaCCCP
wants to merge
72
commits into
main
Choose a base branch
from
refactor/shadcn-audit-zero-warnings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 68 commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
12b8f13
refactor: align UI with shadcn and clear audit findings
9ad52f4
style: finish shadcn semantic color cleanup
dfbaa15
fix: address CodeRabbit review findings
8cca95a
fix: close second-round review findings
603f0bd
fix: use semantic card background token
a36e99f
fix: resolve final CodeRabbit findings
879a607
fix: address remaining review findings
c4460ef
fix: close remaining accessibility findings
e2711be
fix: resolve latest CodeRabbit findings
5b88c1b
fix: address latest UI review findings
1a78030
fix: polish remaining component findings
1cfc512
fix: resolve latest accessibility review findings
7770c6d
fix: close latest UI review findings
3a42fc6
fix: close latest review findings
8f9a544
fix: close final CodeRabbit findings
1a04720
fix: close latest UI review findings
2de4162
fix: close latest accessibility findings
3544acf
fix: close latest component review findings
ff639df
fix: close latest shared control findings
1a91b5d
fix: close latest review findings
57ee771
fix: close latest MCP and discovery findings
a5175b9
fix: close latest accessibility and layout findings
debbaa4
fix: close latest review findings
4e23650
fix: close latest accessibility and state findings
cd5f693
fix: close coderabbit accessibility findings
4926cde
fix: close latest functional accessibility findings
b2c21c9
fix: close latest interaction and theme findings
38302c1
fix: finish final coderabbit findings
8520fc1
fix: close final accessibility and interaction findings
f98f47f
fix: close latest review findings
7c6d537
fix: address follow-up review findings
8bfc616
fix: polish follow-up review findings
e7f7a4e
fix: announce categorization failures
7ddbeb5
fix: close review accessibility findings
9de6d1e
fix: tighten final review controls
4ff8079
fix: harden bundle and navigation checks
b00f5f8
fix: compact repository list controls
2207a44
fix: align UI with official shadcn visual baseline
9abec18
fix: address follow-up review findings
03ef497
fix: close follow-up review findings
c483b4e
fix: address round 32 review findings
d5782bd
fix: stop stepper repeat at bounds
a00503a
fix: address round 34 review findings
c475f85
fix: address round 35 review findings
aeeb3aa
fix: address round 36 review findings
b3630d5
fix: refine shadcn visual consistency
3aa76c7
fix: refine shadcn visual interactions
c085fe5
fix: polish remaining shadcn UI feedback
f2ff824
fix: align scroll containers and hide idle scrollbar
f8a3520
fix: expose release source toggle state
bb0ca3d
fix: finalize populated UI layout verification
4c6dc44
fix: address final coderabbit findings
154e011
fix: close remaining audit findings
3ce5437
fix: polish remaining accessible controls
b3878d2
fix: resolve final audit accessibility findings
3f0ddff
docs: reconcile final test count
82553cd
fix: close final audit findings
b4d7f85
fix: finish remaining review findings
6a02187
fix: close remaining audit comments
825b906
fix: close remaining review findings
206f8f8
fix: resolve remaining review findings
5fd466c
fix: resolve remaining review findings
9634d38
fix: resolve remaining review findings
f5c0201
fix: polish final review findings
a42ec53
fix: close remaining audit findings
9ed3594
fix: close remaining audit findings
81cbdf6
fix: close remaining review findings
cb49bbf
fix: resolve final audit findings
62345f4
fix: resolve final review findings
66a95a0
fix: preserve gist content cache
85c891f
fix: close final review findings
cb6c1ae
fix: finish final review polish
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # 最终浏览器验证 | ||
|
|
||
| 验证时间:2026-08-22 UTC(用户时区为 2026-08-23);构建预览地址:`http://127.0.0.1:4174/`;视口:`1440 × 1000`;浏览器使用隔离 profile 与本地 visual-review fixture,不使用真实凭据,也不写入真实业务数据。此次 fixture 至少包含 1 个仓库、1 个 Release(6 个资产行)、1 个 Gist、1 个 Fork 以及 20 个自定义分类,走查通过应用现有同步、订阅、刷新和卡片点击流程加载数据。 | ||
|
|
||
| ## 关键几何与交互证据 | ||
|
|
||
| | 验证项 | 实测结果 | 截图/报告 | | ||
| |---|---|---| | ||
| | README 弹窗 | dialog `x=150, y=75, width=1130, height=850, right=1280, bottom=925`;相对于 client width 1430 和 viewport height 1000 居中,未超出 viewport 安全边界 | `readme-dialog.png`; `metrics.json` 的 `readmeDialog` | | ||
| | Release 资产面板 | 展开成功;面板 `x=65, y=511, width=1300, right=1365`,在深色主题中相对页面背景使用明显更浅的语义 surface,6 行资产完整可见 | `release-assets.png`; `metrics.json` 的 `releaseAfterAsset` | | ||
| | Fork 每页控件 | 搜索 frame、ForkCard 与 page-size trigger 的右边界均为 `1382`;page-size trigger `x=1302, width=80, right=1382` | `fork-layout.png`; `metrics.json` 的 `forkLayout` | | ||
| | Gist 左右容器 | 侧栏 `y=85, right=288`,右侧搜索 toolbar `y=85, right=1398`;顶部基线相同 | `gist-layout.png`; `metrics.json` 的 `gistLayout` | | ||
| | Gist hover 可读性 | 真实指针 hover 后条目和计数均为 `rgb(248, 250, 252)`,hover 背景为 `rgba(30, 41, 59, 0.5)` | `round42_dropdown_hover_check.py` 输出 | | ||
| | Select 横向稳定 | Release、Gist、Fork 三个下拉在 closed/open/closed 三态中 body 与 root 均保持 `x=0, width=1430, right=1430`,`margin-right=0px`;打开时仅出现 `data-scroll-locked=1` | `round42_dropdown_hover_check.py` 输出 | | ||
| | 分类滚动条 | 滚动条元素右边界保持 `x=287`,侧栏卡片右边界 `x=288`;idle/停止后 thumb 透明,滚动态 thumb 为 `rgba(75, 85, 99, 0.8)`,宽度不变化 | `category-idle.png`, `category-scrolling.png`, `category-after-stop.png`; `metrics.json` | | ||
|
|
||
| README、Release、Gist 与 Fork 截图均为 populated state,而不是空状态占位图。Fork 截图包含 `magpie-fork` 卡片;Release 截图包含 `magpie` 的 `Visual Release` 和 6 个资产行;Gist 截图包含真实 fixture 卡片及侧栏计数。分类截图包含 populated repository card;分类滚动 fixture 的 CSS 状态则由同一页面的 idle、scrolling、after-stop 三次截图和 computed style 结果共同验证。 | ||
|
|
||
| ## 产物 | ||
|
|
||
| 本轮截图和几何报告保存在 `ui-screenshots-round42/`,包括 `readme-dialog.png`、`release-assets.png`、`gist-layout.png`、`gist-dialog.png`、`fork-layout.png`、`category-idle.png`、`category-scrolling.png`、`category-after-stop.png` 与 `metrics.json`。这些文件仅作为本地验证证据,不纳入提交;本记录文件本身为 tracked verification record。 | ||
|
|
||
| ## 代码门禁状态 | ||
|
|
||
| 本轮最终完整门禁已通过:`npm run lint`、`npx tsc -b`、`npm run test:run`、`npm run build`、`git diff --check` 与 `npm audit --omit=dev --audit-level=high` 全部成功。测试结果为 31 个测试文件、332 个测试全部通过;legacy entry 为 `2713.22 KiB`,低于 `3000 KiB` 限制;生产依赖审计结果为 `0 vulnerabilities`。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.