-
Notifications
You must be signed in to change notification settings - Fork 157
refactor: align UI with shadcn and clear audit findings #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AmintaCCCP
wants to merge
72
commits into
main
Choose a base branch
from
refactor/shadcn-audit-zero-warnings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
12b8f13
refactor: align UI with shadcn and clear audit findings
9ad52f4
style: finish shadcn semantic color cleanup
dfbaa15
fix: address CodeRabbit review findings
8cca95a
fix: close second-round review findings
603f0bd
fix: use semantic card background token
a36e99f
fix: resolve final CodeRabbit findings
879a607
fix: address remaining review findings
c4460ef
fix: close remaining accessibility findings
e2711be
fix: resolve latest CodeRabbit findings
5b88c1b
fix: address latest UI review findings
1a78030
fix: polish remaining component findings
1cfc512
fix: resolve latest accessibility review findings
7770c6d
fix: close latest UI review findings
3a42fc6
fix: close latest review findings
8f9a544
fix: close final CodeRabbit findings
1a04720
fix: close latest UI review findings
2de4162
fix: close latest accessibility findings
3544acf
fix: close latest component review findings
ff639df
fix: close latest shared control findings
1a91b5d
fix: close latest review findings
57ee771
fix: close latest MCP and discovery findings
a5175b9
fix: close latest accessibility and layout findings
debbaa4
fix: close latest review findings
4e23650
fix: close latest accessibility and state findings
cd5f693
fix: close coderabbit accessibility findings
4926cde
fix: close latest functional accessibility findings
b2c21c9
fix: close latest interaction and theme findings
38302c1
fix: finish final coderabbit findings
8520fc1
fix: close final accessibility and interaction findings
f98f47f
fix: close latest review findings
7c6d537
fix: address follow-up review findings
8bfc616
fix: polish follow-up review findings
e7f7a4e
fix: announce categorization failures
7ddbeb5
fix: close review accessibility findings
9de6d1e
fix: tighten final review controls
4ff8079
fix: harden bundle and navigation checks
b00f5f8
fix: compact repository list controls
2207a44
fix: align UI with official shadcn visual baseline
9abec18
fix: address follow-up review findings
03ef497
fix: close follow-up review findings
c483b4e
fix: address round 32 review findings
d5782bd
fix: stop stepper repeat at bounds
a00503a
fix: address round 34 review findings
c475f85
fix: address round 35 review findings
aeeb3aa
fix: address round 36 review findings
b3630d5
fix: refine shadcn visual consistency
3aa76c7
fix: refine shadcn visual interactions
c085fe5
fix: polish remaining shadcn UI feedback
f2ff824
fix: align scroll containers and hide idle scrollbar
f8a3520
fix: expose release source toggle state
bb0ca3d
fix: finalize populated UI layout verification
4c6dc44
fix: address final coderabbit findings
154e011
fix: close remaining audit findings
3ce5437
fix: polish remaining accessible controls
b3878d2
fix: resolve final audit accessibility findings
3f0ddff
docs: reconcile final test count
82553cd
fix: close final audit findings
b4d7f85
fix: finish remaining review findings
6a02187
fix: close remaining audit comments
825b906
fix: close remaining review findings
206f8f8
fix: resolve remaining review findings
5fd466c
fix: resolve remaining review findings
9634d38
fix: resolve remaining review findings
f5c0201
fix: polish final review findings
a42ec53
fix: close remaining audit findings
9ed3594
fix: close remaining audit findings
81cbdf6
fix: close remaining review findings
cb49bbf
fix: resolve final audit findings
62345f4
fix: resolve final review findings
66a95a0
fix: preserve gist content cache
85c891f
fix: close final review findings
cb6c1ae
fix: finish final review polish
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # 审计与质量门禁摘要 | ||
|
|
||
| ## 代码与类型审计 | ||
|
|
||
| 本轮审计清理了共享 shadcn 原语的 Fast Refresh 非组件导出警告,补齐 `autoSync.githubToken.test.ts` 的 Vitest 显式导入,修复 `BackendPanel.test.tsx` 的未使用参数,并为 `githubListsApi.ts` 的分页响应和游标补齐显式类型。`VectorSearchSettings.tsx` 的未使用 Hook 依赖也已移除。当前 `npm run lint` 与 `npx tsc -b` 均通过且没有诊断输出。 | ||
|
|
||
| ## 设计系统审计 | ||
|
|
||
| 全局主题已引入 shadcn 默认语义变量:background、foreground、card、popover、primary、secondary、muted、accent、destructive、border、input、ring 和 radius。共享 Button、Badge、Input、Textarea、Card、Select、Checkbox、Switch、RadioGroup、Slider、Tabs、Dialog 与 AlertDialog 已采用官方 demo 风格的默认变体和状态。旧 Linear 类名保留为兼容别名,但其实际颜色已映射到 shadcn 语义变量,业务逻辑和状态流未改变。 | ||
|
|
||
| ## 安全审计 | ||
|
|
||
| `npm audit --omit=dev --audit-level=high` 最终报告 `found 0 vulnerabilities`。仓库没有使用 `react-router-dom`,因此移除了该未使用依赖及其传递漏洞来源;没有执行破坏性路由升级。 | ||
|
|
||
| ## UI 与交互走查 | ||
|
|
||
| 生产预览已走查仓库页、设置页、AI 配置页、新增 AI 表单、WebDAV 空状态、备份恢复面板和主题共享控件。重点复测了导航 active 状态、AI 搜索空查询 disabled 状态、Radix Select 打开与切换、Checkbox 展开默认提示词、Textarea、Switch checked 状态、取消表单和空状态恢复。AI 搜索及主操作按钮的深色主题前景色覆盖问题已修复。浏览器控制台仅有预期的应用初始化与本地模式信息,没有未捕获异常或 React/Radix 警告。 | ||
|
|
||
| ## 最终质量门禁 | ||
|
|
||
| | 检查项 | 结果 | | ||
| |---|---| | ||
| | `npm run lint` | 通过 | | ||
| | `npx tsc -b` | 通过 | | ||
| | `npm run test:run` | 29 个测试文件、326 个测试全部通过 | | ||
| | `npm run build` | 通过,无 chunk 警告 | | ||
| | `git diff --check` | 通过 | | ||
| | `npm audit --omit=dev --audit-level=high` | 0 vulnerabilities | | ||
|
|
||
| 审计补充:组件目录中的旧 brand/status/Linear 色类已清零;index.css 仅剩 option 元素和仓库成功状态的两处兼容选择器,正在改为 `background/card/foreground/green-600` 语义。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # 最终浏览器验证 | ||
|
|
||
| 验证时间:2026-08-21。 | ||
|
|
||
| 生产预览地址:`http://127.0.0.1:4173/`。 | ||
|
|
||
| 页面标题正确:`GitHub Stars Manager - AI-Powered Repository Management`。 | ||
|
|
||
| 登录壳层正常渲染,包含中文/英文切换、主题切换、GitHub Personal Access Token 输入框、连接按钮和创建 token 外链。 | ||
|
|
||
| 控制台检查结果:入口模块加载、React root 创建、应用渲染、store hydration 均成功;后端不可用时正确进入 local-only 模式;未发现 React、Radix 或资源加载错误。 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.