This repository was archived by the owner on Oct 23, 2026. It is now read-only.
Repository navigation
fix: do not retry a missing GraphQL alias, and stop the thread pass after 10 minutes - #112
Merged
Merged
Conversation
…fter 10 minutes (#107) A GraphQL NOT_FOUND for one alias (a deleted or transferred number) made gh exit 1; _gh retried it as transient (14 s of sleeps) and the thread pass bisected the batch, about 80 s per number and ten numbers a run, every run, since gone threads were never cached. Their PR titles in the body could also match 'rate limit' and end the pass early. gh_graphql now returns the data when the only errors are NOT_FOUND, a gone thread gets an empty cache entry, and the pass has a 10 minute budget so a cold-cache run still builds and deploys with what it has.
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #108 (thanks @savvaniss) and fixes #107 at the cause.
Run 39296621500 (last success, 19 Oct) already took 19 min; the log shows why:
ghexits 1,_ghtreats it as transient and sleeps 2+4+8 s, thenfetch_threadsbisects the batch (25, 13, 6, 3, 2, 1). That is about 80 s per number, ten numbers per run (about 13 min), and the numbers were never cached, so every run paid again.is_primary_limitended the pass with 684 threads unread.Changes:
gh_graphqlreturns the data when the only errors are NOT_FOUND (null for the alias); no retry, no bisecting.THREAD_BUDGET_SECONDS(10 min); the site builds and deploys with what it has and the next run carries on (api.partial, with the reason intruncated).AI-assisted: yes (Claude Code)