Repository navigation
Fields refuse the site theme's fixed height - #39
Merged
Merged
Conversation
Astra pins bare inputs and selects at `height: 40px`. Our fields set their size through line-height and padding — 24px of line inside 18px of padding — which needs 44px, so under Astra every select lost 4px and cut its descenders off: "Engineering" rendered with both g's missing their tails. Any site theme that sizes fields with a fixed height does the same to us. `height: auto`, explicitly, on `.atf-form .atf-input`: padding is the height policy here, and the box must be allowed to be as tall as its line. One declaration covers inputs and selects alike, on every form theme, whatever the site theme underneath. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119U4sRRWGcTQdwYreTwpAp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Descenders were cut off in form fields on the front end — "Engineering" in a Neon-themed select rendered with both g's missing their tails.
Why
Astra (the site theme on the QA install) pins bare
input/selectelements atheight: 40px. Our fields size themselves through line-height + padding (24px line inside 18px padding = 44px), and since.atf-form .atf-inputdeclared noheight, the site theme's fixed height won and squeezed a 24px line box into 20px of room. Not Neon-specific — any form theme under any site theme that fixes field heights clips the same way.How
One declaration:
height: autoon.atf-form .atf-input, with a comment explaining that padding is the height policy. Covers inputs and selects alike.Verified on the 8889 front end with the Neon theme: selects back at their natural 44px, descenders intact; the builder and Theme Studio previews were already unaffected (no site-theme CSS there).
🤖 Generated with Claude Code
https://claude.ai/code/session_0119U4sRRWGcTQdwYreTwpAp