Skip to content

[PWGCF] Similar output procedure added for V02 and V0 - #17694

Merged
wenyaCern merged 4 commits into
AliceO2Group:masterfrom
MaximVirta:V02Dev
Sep 1, 2026
Merged

[PWGCF] Similar output procedure added for V02 and V0#17694
wenyaCern merged 4 commits into
AliceO2Group:masterfrom
MaximVirta:V02Dev

Conversation

@MaximVirta

Copy link
Copy Markdown
Contributor

Increased modularity, removed nch study, updated output format for V02

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 4 warnings, 🔕 3 disabled

Please consider the following formatting changes to AliceO2Group#17694
wenyaCern
wenyaCern previously approved these changes Sep 1, 2026
@wenyaCern
wenyaCern enabled auto-merge (squash) September 1, 2026 11:21
@alibuild

alibuild commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 8be85d3 at 2026-09-01 14:15:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:852:63: error: unused parameter 'multiplicity' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:852:91: error: unused parameter 'rndm' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 8be85d3 at 2026-09-01 14:20:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:852:63: error: unused parameter 'multiplicity' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:852:91: error: unused parameter 'rndm' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 8be85d3 at 2026-09-01 14:45:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 56 warnings.'
Found 6 errors and 56 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/82bdba0f8dfa2e0e1272af2acbb09cb94a9c573c/O2Physics-code-check/errors.txt
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:17:1: error: included header FlowContainer.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:54:1: error: included header types.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:852:63: error: parameter 'multiplicity' is unused [misc-unused-parameters,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:852:63: error: unused parameter 'multiplicity' [clang-diagnostic-unused-parameter,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:852:91: error: parameter 'rndm' is unused [misc-unused-parameters,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:852:91: error: unused parameter 'rndm' [clang-diagnostic-unused-parameter,-warnings-as-errors]
++ [[ 56 -gt 0 ]]
++ cat /sw/BUILD/82bdba0f8dfa2e0e1272af2acbb09cb94a9c573c/O2Physics-code-check/warnings.txt
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:511:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:519:29: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:647:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:675:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:690:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:699:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:708:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:717:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:719:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:810:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:815:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:819:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:821:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:823:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:825:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:827:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:842:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:844:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:846:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1036:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1038:146: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1040:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1062:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1064:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1066:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1071:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1073:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1077:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1079:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1083:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1085:13: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1089:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1090:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1092:36: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

auto-merge was automatically disabled September 1, 2026 15:02

Head branch was pushed to by a user without write access

@wenyaCern
wenyaCern enabled auto-merge (squash) September 1, 2026 15:36
@wenyaCern
wenyaCern merged commit 8adb426 into AliceO2Group:master Sep 1, 2026
21 of 23 checks passed
@MaximVirta
MaximVirta deleted the V02Dev branch September 2, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants