Skip to content

[PWGDQ] correct MFT propagation to vertex in QA tasks - #17663

Merged
mcoquet642 merged 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-fix-mft-extrapolation-to-vertex
Aug 31, 2026
Merged

[PWGDQ] correct MFT propagation to vertex in QA tasks#17663
mcoquet642 merged 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-fix-mft-extrapolation-to-vertex

Conversation

@aferrero2707

Copy link
Copy Markdown
Contributor

The propagation of the MFT and global forward tracks to the vertex is now performed with the official propagateTrackParCovFwd() function from the forward track utilities.

The propagation of the MFT and global forward tracks to the vertex is now
performed with the official propagateTrackParCovFwd() function from the
forward track utilities
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 61 warnings, 🔕 12 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4cb561c at 2026-08-30 21:34:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 72 warnings.'
Found 4 errors and 72 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/77c093b4153b80c59b892f048a08331b771a7463/O2Physics-code-check/errors.txt
PWGDQ/Tasks/muonGlobalAlignment.cxx:59:1: error: included header Vector3D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:60:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1500:15: error: no header providing "ROOT::Math::PxPyPzMVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1519:17: error: no header providing "ROOT::Math::XYZVector" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 72 -gt 0 ]]
++ cat /sw/BUILD/77c093b4153b80c59b892f048a08331b771a7463/O2Physics-code-check/warnings.txt
PWGDQ/Tasks/qaMatching.cxx:1241:11: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGDQ/Tasks/qaMatching.cxx:1241:26: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGDQ/Tasks/qaMatching.cxx:1241:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1269:11: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGDQ/Tasks/qaMatching.cxx:1269:26: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGDQ/Tasks/qaMatching.cxx:1269:70: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGDQ/Tasks/qaMatching.cxx:1269:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1285:31: warning: redundant explicit casting to the same type 'int' as the sub-expression, remove this casting [readability-redundant-casting]
PWGDQ/Tasks/qaMatching.cxx:1329:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGDQ/Tasks/qaMatching.cxx:1345:35: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1399:35: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1403:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1418:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1422:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1435:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1449:29: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1458:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1720:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1740:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1770:73: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1774:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1776:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1780:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1789:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1824:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1826:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1832:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1835:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1846:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1862:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1903:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1905:80: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1927:111: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1933:107: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1952:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1966:36: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@aferrero2707

Copy link
Copy Markdown
Contributor Author

@mcoquet642 this is the fix for the FWD track extrapolation to the vertex that you suggested in #17461.

Could you please have a look?
The code-check errors are actually false positives, for the warnings I will prepare a separate PR.
Thanks!

@mcoquet642
mcoquet642 merged commit 3a4cc0c into AliceO2Group:master Aug 31, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants