Repository navigation
[Aikido] Fix shell injection bypass via backtick operator in HookAst.cpp - #503
Closed
aikido-autofix[bot] wants to merge 1 commit into
Closed
aikido-autofix[bot] wants to merge 1 commit into
aikido-autofix[bot] wants to merge 1 commit into
Conversation
…alls for security hooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses a shell injection vulnerability where PHP backtick operators bypassed shell-injection interception by transforming ZEND_AST_SHELL_EXEC nodes into shell_exec() function calls at the AST processing level. The fix ensures backtick expressions are subject to the same security hooks and EVENT_PRE_SHELL_EXECUTED emission as explicitly invoked shell functions. Changes were made to lib/php-extension/HookAst.cpp to implement the AST transformation logic.
✅ 1 issue fixed by this PR
exec,shell_exec,system,passthru,popen, andproc_open, while the generic dispatcher selects handlers only by the invoked function name. PHP backticks are a language-level shell-execution construct rather than a call to the registeredshell_execfunction, so this function-hook path does not emitEVENT_PRE_SHELL_EXECUTED. Consequently, an application route that embeds request data in a backtick command can execute injected shell syntax despite the extension's shell-injection blocking mode.