Repository navigation
fix(spec): refuse to send the key over plain http - #96
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A base URL that starts
http://sent the key unencrypted. Pointing a client athttp://api.postcode.gov.ngdid exactly that before the redirect came back (seen 12 October 2026).spec/client.jsongainsrefuses_plain_http, and the Rust, Python, JavaScript, and Java clients each prove it. The refusal is a transport failure value, raised before anything is sent.localhost,127.0.0.1, and::1stay allowed, so local mocks keep working.NG_POSTCODE_BASE_URLat start, with two shared cases inspec/mcp-env.json.This changes behaviour for anyone using a plain http base URL on another machine.