Skip to content

fix(spec): refuse to send the key over plain http - #96

Merged
Adeniyikayodee merged 3 commits into
mainfrom
fix/refuse-plain-http
Oct 12, 2026
Merged

Adeniyikayodee merged 3 commits into
mainfrom
fix/refuse-plain-http

Conversation

@Adeniyikayodee

Copy link
Copy Markdown
Owner

A base URL that starts http:// sent the key unencrypted. Pointing a client at http://api.postcode.gov.ng did exactly that before the redirect came back (seen 12 October 2026).

  • spec/client.json gains refuses_plain_http, and the Rust, Python, JavaScript, and Java clients each prove it. The refusal is a transport failure value, raised before anything is sent.
  • localhost, 127.0.0.1, and ::1 stay allowed, so local mocks keep working.
  • Both MCP servers refuse a plain http NG_POSTCODE_BASE_URL at start, with two shared cases in spec/mcp-env.json.

This changes behaviour for anyone using a plain http base URL on another machine.

@Adeniyikayodee
Adeniyikayodee merged commit d50f040 into main Oct 12, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant