Repository navigation
fix(python): wait out a NIPOST rate limit once when confirming a CSV - #94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--confirmstopped at the first429, so a file with more distinct codes than the limit allows was left mostly unconfirmed.It now waits a minute and asks again, once for each code. A second
429, or any other failure, stops the confirming as before.NIPOST sends
x-ratelimit-limit: 600and does not publish the window or aRetry-After, so the minute is a guess. I did not exhaust the limit against their servers to measure it.