Skip to content

fix(settings): route the notifications settings group - #972

Merged
ErikBjare merged 1 commit into
masterfrom
fix/notifications-settings-route
Sep 9, 2026
Merged

fix(settings): route the notifications settings group#972
ErikBjare merged 1 commit into
masterfrom
fix/notifications-settings-route

Conversation

@ErikBjare

Copy link
Copy Markdown
Member

Navigating from the settings menu to /#/settings/notifications showed the 404 page: the notifications group (AwNotifySettings, added with the shared aw-notify threshold work) was never added to the :group route matcher in route.js, whose own comment warns that new groups in Settings.vue must be added there.

One-line fix: add notifications to the alternation.

Repro: Settings → Notifications in the menu → 404 ("Woops, this page was not found!"). After fix: panel renders and the URL survives reloads like the other groups.

The notifications group (AwNotifySettings) was added to Settings.vue
without extending the :group route matcher, so the settings menu linked
to /settings/notifications but the router fell through to the 404 page.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T08:44:18.109407Z 93fd673 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds the existing Notifications settings group to the settings route matcher, allowing /settings/notifications to resolve to the Settings view instead of the catch-all 404.

  • Matches the notifications group identifier already defined in Settings.vue.
  • Preserves the specific category-builder route and existing settings route behavior.

Confidence Score: 5/5

The PR appears safe to merge and correctly restores routing for the Notifications settings panel.

The added matcher value agrees with the existing group ID, navigation URL, component mapping, and route-prop handling, with no route-ordering conflict.

Important Files Changed

Filename Overview
src/route.js Extends the settings group route matcher with the existing notifications group; no issues identified.

Reviews (1): Last reviewed commit: "fix(settings): route the notifications s..." | Re-trigger Greptile

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.25%. Comparing base (3e7fb7c) to head (93fd673).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #972   +/-   ##
=======================================
  Coverage   52.25%   52.25%           
=======================================
  Files          48       48           
  Lines        2943     2943           
  Branches      692      692           
=======================================
  Hits         1538     1538           
+ Misses       1385     1322   -63     
- Partials       20       83   +63     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ErikBjare
ErikBjare merged commit 8365c47 into master Sep 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant