fix(settings): route the notifications settings group - #972
Conversation
The notifications group (AwNotifySettings) was added to Settings.vue without extending the :group route matcher, so the settings menu linked to /settings/notifications but the router fell through to the 404 page.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Greptile SummaryThis PR adds the existing Notifications settings group to the settings route matcher, allowing
Confidence Score: 5/5The PR appears safe to merge and correctly restores routing for the Notifications settings panel. The added matcher value agrees with the existing group ID, navigation URL, component mapping, and route-prop handling, with no route-ordering conflict. Important Files Changed
Reviews (1): Last reviewed commit: "fix(settings): route the notifications s..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #972 +/- ##
=======================================
Coverage 52.25% 52.25%
=======================================
Files 48 48
Lines 2943 2943
Branches 692 692
=======================================
Hits 1538 1538
+ Misses 1385 1322 -63
- Partials 20 83 +63 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Navigating from the settings menu to
/#/settings/notificationsshowed the 404 page: thenotificationsgroup (AwNotifySettings, added with the shared aw-notify threshold work) was never added to the:grouproute matcher inroute.js, whose own comment warns that new groups in Settings.vue must be added there.One-line fix: add
notificationsto the alternation.Repro: Settings → Notifications in the menu → 404 ("Woops, this page was not found!"). After fix: panel renders and the URL survives reloads like the other groups.