Skip to content

Feedback Page - Matches mockup + has functionalities - #320

Merged
saa938 merged 13 commits into
AP-Students:frqfrom
Apurva-26:frq-footer-global
Jul 22, 2026
Merged

Feedback Page - Matches mockup + has functionalities#320
saa938 merged 13 commits into
AP-Students:frqfrom
Apurva-26:frq-footer-global

Conversation

@Apurva-26

Copy link
Copy Markdown
Contributor

Description

The FRQ feedback page now closely matches the mockup. The parts that need to be functional are working (so the FRQ scrolling, next/previous and right/left buttons are working as intended, the footer works, etc.).

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Demo

image image image

How Has This Been Tested? How can the reviewer test it?

I just ran the server (npm run dev) to see my changes and to ensure everything works. I used the fallback data instead of using the emulators as that would allow me to see the data on display on the page. To test it, just do npm run dev and go to "http://localhost:3000/frq-feedback/test" and it should work.

Checklist

  • I have performed a self-review of my own code

@saa938
saa938 changed the base branch from main to frq July 20, 2026 00:33
@Famousmaster206
Famousmaster206 requested a review from Copilot July 20, 2026 03:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@saa938 saa938 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve conflicts also

btw did @Lermonade tell you to have each frq-feedback[id] page to have the same hardcoded data

Comment thread src/lib/firebase.ts Outdated
@saa938 saa938 linked an issue Jul 22, 2026 that may be closed by this pull request
7 tasks
@saa938
saa938 merged commit b526acd into AP-Students:frq Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

INTERN - Build FRQ Feedback Page

3 participants