Create FRQ grading page skeleton - #311
Merged
Lermonade merged 4 commits intoJul 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces the initial skeleton for an FRQ grading flow in the Next.js app router, including a list page for ungraded FRQ document IDs and a dynamic detail page that fetches an individual FRQ and renders a placeholder UI.
Changes:
- Added
/frq-gradingclient page to list Firestore document IDs from theungraded-frqscollection and link to each detail route. - Added
/frq-grading/[id]client page to fetch a specific FRQ document by route param and pass it to a renderer. - Added
FRQGradingRendererplaceholder component to display a basic “found/not found” message.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/components/frq/gradingRenderer.tsx | Adds a placeholder renderer for FRQ grading, currently showing found/not-found messaging. |
| src/app/frq-grading/page.tsx | Implements the ungraded FRQ ID list page backed by Firestore. |
| src/app/frq-grading/[id]/page.tsx | Implements the dynamic FRQ grading page that fetches one FRQ doc by ID. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thx for the pr. Check some of the stuff copilot said. Also, im pretty sure the pr should merge to the frq branch of the repo, not the main branch. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@Famousmaster206 Resolved and thanks for letting me know, I'll keep that in mind from now on! |
added 2 commits
July 8, 2026 21:56
saa938
pushed a commit
that referenced
this pull request
Jul 19, 2026
* Create FRQ grading page skeleton * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Address PR review feedback --------- Co-authored-by: Xylina Delgado <chain.userxd@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created the initial FRQ grading page skeleton by adding an ungraded FRQ list page, a dynamic FRQ grading page, and a basic FRQGradingRenderer component.
The list page retrieves document IDs from the ungraded-frqs Firestore collection and links each item to its corresponding grading page. The grading page fetches the selected FRQ based on the URL parameter and passes the result to FRQGradingRenderer, which currently displays a simple success or failure message depending on whether the FRQ exists.
Pull request type
Feature for FRQ Grading
Please check the type of change your PR introduces:
A summary of the change, anything else that will help review this PR
Demo
How Has This Been Tested? How can the reviewer test it?
Checklist