Skip to content

Create FRQ grading page skeleton - #311

Merged
Lermonade merged 4 commits into
AP-Students:frqfrom
xylinadelgado:feature/frq-grading-skeleton
Jul 9, 2026
Merged

Create FRQ grading page skeleton#311
Lermonade merged 4 commits into
AP-Students:frqfrom
xylinadelgado:feature/frq-grading-skeleton

Conversation

@xylinadelgado

Copy link
Copy Markdown
Contributor

Description

Created the initial FRQ grading page skeleton by adding an ungraded FRQ list page, a dynamic FRQ grading page, and a basic FRQGradingRenderer component.

The list page retrieves document IDs from the ungraded-frqs Firestore collection and links each item to its corresponding grading page. The grading page fetches the selected FRQ based on the URL parameter and passes the result to FRQGradingRenderer, which currently displays a simple success or failure message depending on whether the FRQ exists.

Pull request type

Feature for FRQ Grading
Please check the type of change your PR introduces:

  • Bugfix
  • [x ] Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

A summary of the change, anything else that will help review this PR

Demo

  • /frq-grading displays the list of ungraded FRQ IDs.
  • Clicking an FRQ navigates to /frq-grading/[id].
  • Existing FRQs display a success message.
  • Invalid or missing FRQs display "FRQ not found."

How Has This Been Tested? How can the reviewer test it?

  • Start the Firebase Emulator.
  • Add a test document to the ungraded-frqs Firestore collection.
  • Run the application locally with npm run dev.
  • Change endpoint to /frq-grading.
  • Verify the list of FRQ IDs is displayed.
  • Click an FRQ ID and verify the grading page displays the success message.
  • Navigate to an invalid FRQ ID (for example /frq-grading/does-not-exist) and verify the page displays "FRQ not found."
  • Ran npm run build successfully to verify the project builds without errors.

Checklist

  • [ x] I have performed a self-review of my own code

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces the initial skeleton for an FRQ grading flow in the Next.js app router, including a list page for ungraded FRQ document IDs and a dynamic detail page that fetches an individual FRQ and renders a placeholder UI.

Changes:

  • Added /frq-grading client page to list Firestore document IDs from the ungraded-frqs collection and link to each detail route.
  • Added /frq-grading/[id] client page to fetch a specific FRQ document by route param and pass it to a renderer.
  • Added FRQGradingRenderer placeholder component to display a basic “found/not found” message.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/components/frq/gradingRenderer.tsx Adds a placeholder renderer for FRQ grading, currently showing found/not-found messaging.
src/app/frq-grading/page.tsx Implements the ungraded FRQ ID list page backed by Firestore.
src/app/frq-grading/[id]/page.tsx Implements the dynamic FRQ grading page that fetches one FRQ doc by ID.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/frq/gradingRenderer.tsx Outdated
Comment thread src/app/frq-grading/page.tsx Outdated
Comment thread src/app/frq-grading/page.tsx
Comment thread src/app/frq-grading/page.tsx
Comment thread src/app/frq-grading/[id]/page.tsx Outdated
@Famousmaster206

Copy link
Copy Markdown
Contributor

Thx for the pr. Check some of the stuff copilot said. Also, im pretty sure the pr should merge to the frq branch of the repo, not the main branch.

@xylinadelgado
xylinadelgado changed the base branch from main to frq July 8, 2026 23:01
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@xylinadelgado

Copy link
Copy Markdown
Contributor Author

@Famousmaster206 Resolved and thanks for letting me know, I'll keep that in mind from now on!

@Lermonade
Lermonade merged commit 0f9d56b into AP-Students:frq Jul 9, 2026
saa938 pushed a commit that referenced this pull request Jul 19, 2026
* Create FRQ grading page skeleton

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Address PR review feedback

---------

Co-authored-by: Xylina Delgado <chain.userxd@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants