fix: take the upstream EDM into account when reading old schemas - #1019
Open
veprbl wants to merge 1 commit into
Open
fix: take the upstream EDM into account when reading old schemas#1019veprbl wants to merge 1 commit into
veprbl wants to merge 1 commit into
Conversation
_read_old_schemas re-reads the current and the old datamodel definitions through a fresh PodioConfigReader in order to compare them, but did not pass the upstream EDM along. Validation of the freshly read models then cannot resolve any type coming from the upstream EDM and code generation fails with e.g. DefinitionError: position of component edm4eic::TrackPoint is not a builtin type, another component or one from the upstream EDM This makes OLD_DESCRIPTIONS unusable for any datamodel that is built on top of an upstream EDM. The comparison itself never needs the upstream components, it is only the validation of the re-read models that trips over them, so simply passing the upstream EDM along is enough. Assisted-by: Claude Opus 5 <noreply@anthropic.com>
Member
|
Can you expand on what is failing and how? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make OLD_DESCRIPTIONS usable for downstream models.
BEGINRELEASENOTES
OLD_DESCRIPTIONScan be used together withUPSTREAM_EDM.ENDRELEASENOTES